chore(gatsby): upgrade from lmdb-store to lmdb #34576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: data
pieh
force-pushed
the
chore/upgrade/lmdb
branch
from
cbf00da
to
34d1fc5
Compare
pieh
commented
Jan 25, 2022
pieh
force-pushed
the
chore/upgrade/lmdb
branch
2 times, most recently
from
9d0a414
to
34d1fc5
Compare
pieh
force-pushed
the
chore/upgrade/lmdb
branch
from
34d1fc5
to
9b010e6
Compare
pieh
commented
Feb 11, 2022
| // In `gatsby serve` case we might try to open it twice - once for engines | ||
| // and second to get access to `SitePage` nodes (to power trailing slashes | ||
| // redirect middleware). This ensure there is single instance within a process. | ||
| // Using more instances seems to cause weird random errors. |
There was a problem hiding this comment.
this seems new with lmdb@2 - we have trailing slashes in master and released generally and not seeing it there (with lmdb-store@1)
There was a problem hiding this comment.
Oh, and also to clarify - this module does already prevent opening multiple DBs. The problem with gatsby serve that this module is used as-is and then it can be used in bundled graphql-engine, so just there are 2 separate instances of this module alive
pieh
added
the
topic: core
imjoshin
reviewed
Feb 15, 2022
| // In `gatsby serve` case we might try to open it twice - once for engines | ||
| // and second to get access to `SitePage` nodes (to power trailing slashes | ||
| // redirect middleware). This ensure there is single instance within a process. | ||
| // Using more instances seems to cause weird random errors. |
imjoshin
approved these changes
Feb 15, 2022
pieh
added
the
bot: merge on green
2 tasks
This was referenced May 26, 2022
This was referenced May 28, 2022
This was referenced May 28, 2022
This was referenced Jul 21, 2022
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In practice this bumps our
lmdb-storeone major version (there was name change to justlmdbwith version 2). And allow usage ofclearKeptSync(there is some internal use of that directly in lmdb@2 now, but this is cheap, so just to be on safe side, we still call it)Related Issues
[ch-45417]