Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(starters): Minimal TS starter gatsby-config.ts #35128

Merged
merged 2 commits into from Mar 21, 2022
Merged

feat(starters): Minimal TS starter gatsby-config.ts #35128

merged 2 commits into from Mar 21, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Mar 14, 2022 •
edited

Description

Originally part of #35074.

Change the gatsby-starter-minimal-ts Gatsby config from a JS to TS file. This should only be merged after the next minor release to avoid breaking existing create-gatsby functionality.

Documentation

No change needed, documented in https://www.gatsbyjs.com/docs/how-to/custom-configuration/typescript/#gatsby-configts

Related Issues

[sc-47519]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 14, 2022
@tyhopp tyhopp added status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. labels Mar 14, 2022
@tyhopp tyhopp marked this pull request as draft March 14, 2022 08:40
tyhopp added a commit that referenced this pull request Mar 14, 2022
@tyhopp
Extract out starter gatsby-config.ts to #35128
1f8321a
@tyhopp tyhopp mentioned this pull request Mar 14, 2022
Merged
@nickspaargaren nickspaargaren mentioned this pull request Mar 16, 2022
Closed
@tyhopp tyhopp force-pushed the feat/minimal-ts-starter-gatsby-config branch from d402f50 to 9669325 Compare March 17, 2022 06:42
@LekoArts LekoArts removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Mar 17, 2022
@tyhopp tyhopp mentioned this pull request Mar 17, 2022
Merged
@tyhopp tyhopp added status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change labels Mar 17, 2022
@tyhopp tyhopp force-pushed the feat/minimal-ts-starter-gatsby-config branch from 9669325 to 89fca25 Compare March 21, 2022 06:24
@tyhopp tyhopp marked this pull request as ready for review March 21, 2022 07:23
@tyhopp tyhopp removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Mar 21, 2022
@LekoArts LekoArts merged commit 50d6735 into master Mar 21, 2022
@LekoArts LekoArts deleted the feat/minimal-ts-starter-gatsby-config branch March 21, 2022 07:43
@LekoArts LekoArts added this to the TypeScript Improvements milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
Milestone
TypeScript AOT Compilation
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyhopp @LekoArts