Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[v2] remove static-site-generator-webpack-plugin and render html files ourselves #4912
changed the title from
remove static-site-generator-webpack-plugin and render html files ourselves
[v2] remove static-site-generator-webpack-plugin and render html files ourselves
Apr 10, 2018
Performance comparison from building locally current v2 vs this branch using freecodecamp guide as benchmark site (2780 pages) - this is only for "Building static HTML for pages" step!
Note: With current v2 we need to run with increased memory limit using
Memory usage (peak) [MB]:
This was actually suprising to me how "lazy" node / V8 is with releasing memory, but I guess garbage collection can be expensive.
Time spent [s]:
Now this is suprise for me that there is time improvement when not using
Time improvment from v2 to this PR I think could be explained with v2 doing promise.all on all paths and almost 2800 workers ran in parallel being starved on resources slowing things down plus maybe some overhead from using webpack for handling output.
Just in case dump all time/memory metrics is in this spreadsheet https://docs.google.com/spreadsheets/d/1TyUc_J-0v2Te0XIcEM-V79Ut-_e1Wxky2rrVLPVY9FM/edit?usp=sharing - first sheet being summary same as in this comment and other sheet with detailed data