New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting query runner error #5545

Merged
merged 2 commits into from May 25, 2018

Conversation

Projects
None yet
4 participants
@alexluong
Copy link
Contributor

alexluong commented May 24, 2018

#5379

I tidied up the query error. If anyone can review and give me feedback on this, I'd appreciate it. It's my first open-source pull request, so please let me know if I'm doing anything wrong. Thanks.

Signed-off-by: @alexluong

alexluong added some commits May 24, 2018

@gatsbybot

This comment has been minimized.

Copy link

gatsbybot commented May 24, 2018

Deploy preview for using-drupal ready!

Built with commit 5893ec6

https://deploy-preview-5545--using-drupal.netlify.com

@gatsbybot

This comment has been minimized.

Copy link

gatsbybot commented May 24, 2018

Deploy preview for gatsbygram ready!

Built with commit 5893ec6

https://deploy-preview-5545--gatsbygram.netlify.com

@m-allanson

This comment has been minimized.

Copy link
Member

m-allanson commented May 25, 2018

Thanks @alexluong and welcome to open source :) The code looks good to me 👍. Could you add a screenshot of what the new formatting looks like?

And thanks for adding the Signed-off-by: message to your pull request - it turned out that having to do that was deeply unpopular so that's not a requirement any more.

@alexluong

This comment has been minimized.

Copy link
Contributor Author

alexluong commented May 25, 2018

Thank you @m-allanson for the feedback. Here's a screenshot of what the query error looks like:
screen shot 2018-05-24 at 4 55 53 am

@alexluong

This comment has been minimized.

Copy link
Contributor Author

alexluong commented May 25, 2018

We can also indent everything in 2 spaces if you think that would make the whole error log more readable.

@m-allanson
Copy link
Member

m-allanson left a comment

Oh I just realised you posted that screenshot in the other thread already, thank you. 😅

Looks good!

@m-allanson m-allanson merged commit 12c20f8 into gatsbyjs:master May 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@alexluong alexluong deleted the alexluong:topics/improve-formatting-query-runner-error branch Jul 20, 2018

@jlengstorf

This comment has been minimized.

Copy link
Member

jlengstorf commented Feb 16, 2019

Hiya @alexluong! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

1 similar comment
@jlengstorf

This comment has been minimized.

Copy link
Member

jlengstorf commented Feb 16, 2019

Hiya @alexluong! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment