Adapting webpack config to use webpack-configurator plugin method #626

Merged
merged 1 commit into from Jan 9, 2017

Projects

None yet

2 participants

@antoniocapelo
Contributor
antoniocapelo commented Jan 6, 2017 edited

This PR aims to use the webpack configurator plugin methods so that the user can remove and add/customise webpack plugins. The documentation on README.md already describes this behavior so I don't think it needs to be updated.

I did not find any tests regarding the usage of the loaders methods of wp-configurator, so I did not add for the plugin, @KyleAMathews do you feel its needed?

(This feature request is mentioned here)

acapelo Adapting webpack config to use webpack-configurator plugin method
simplifying plugin calls

reusing common plugin definition
40c4f72
@KyleAMathews
Contributor

Thanks for doing this! Yes... for some reason this wasn't done back when we switched over to webpack-configurator.

Jest snapshots would be perfect for testing this... which (Jest) I've moved the 1.0 stuff to use. But for now, it'd be pretty tedious to setup a test for this so doesn't seem worth it.

@KyleAMathews KyleAMathews merged commit b4d585a into gatsbyjs:master Jan 9, 2017

1 of 2 checks passed

deploy/netlify Deploy preview failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@KyleAMathews
Contributor

0.12.28 is out with this pr 🎉

@antoniocapelo
Contributor

🎉 awesome! Thanks and keep up the good work with gatsby!

gatsby

@antoniocapelo antoniocapelo deleted the antoniocapelo:support-wp-configurator-plugins branch Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment