Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creating-global-styles.md #7699

Merged
merged 2 commits into from Aug 28, 2018

Conversation

@erinfox
Copy link
Contributor

commented Aug 28, 2018

Added new wording around importing global styles based on this comment

Closes #7447

Update creating-global-styles.md
Added new wording around importing global styles based on [this comment](#7413 (comment)) 

Closes #7447
@@ -25,6 +25,9 @@ a {

Then, include the stylesheet in your site's `gatsby-browser.js` file.

> _Note: This solution works when including css as those styles are extracted when building the js but not for css-in-js.

This comment has been minimized.

Copy link
@k3rn31p4nic

k3rn31p4nic Aug 28, 2018

Member

You're starting the _ for emphasis, but you're not ending it. And therefore, it's not being rendered properly (as seen in the screenshot below). Maybe, you forgot to end it with _?
image

@KyleAMathews

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2018

Deploy preview for using-contentful failed.

Built with commit 2961db2

https://app.netlify.com/sites/using-contentful/deploys/5b856a8bb13fb12f1d553e0a

@m-allanson

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

Nice, thanks!

@m-allanson m-allanson merged commit 84959bd into gatsbyjs:master Aug 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@gatsbot

This comment has been minimized.

Copy link

commented Aug 28, 2018

Holy buckets, @erinfox — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.