New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migrating-from-v1-to-v2.md #8302

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
3 participants
@pavanpodila
Contributor

pavanpodila commented Sep 19, 2018

Added a note around possible wrong import of graphql from the graphql package instead of gatsby. I was bitten by this badly and took more than an hour to figure out!

Update migrating-from-v1-to-v2.md
Added a note around possible wrong import of `graphql` from the `graphql` package instead of `gatsby`. I was bitten by this badly and took more than an hour to figure out!
@m-allanson

This comment has been minimized.

Contributor

m-allanson commented Sep 19, 2018

Eeee that's no fun, thanks for the update @pavanpodila 👍 This is the sort of thing we could catch with #7687

@m-allanson m-allanson merged commit c61e0cc into gatsbyjs:master Sep 19, 2018

9 checks passed

ci/circleci: integration Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prod_ui Your tests passed on CircleCI!
Details
ci/circleci: ui Your tests passed on CircleCI!
Details
ci/circleci: unit-node10 Your tests passed on CircleCI!
Details
ci/circleci: unit-node6 Your tests passed on CircleCI!
Details
ci/circleci: unit-node8 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@gatsbot

This comment has been minimized.

gatsbot bot commented Sep 19, 2018

Holy buckets, @pavanpodila — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pavanpodila

This comment has been minimized.

Contributor

pavanpodila commented Sep 20, 2018

Eeee that's no fun, thanks for the update @pavanpodila 👍 This is the sort of thing we could catch with #7687

The eslint-plugin would be a perfect fit!!

@pavanpodila pavanpodila deleted the pavanpodila:patch-1 branch Sep 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment