Add blog post to publish to Azure #8868

dougajmcdonald · 2018-10-06T16:22:42Z

This PR add's a blog post which describes how to create a gatsby blog from the starter and publish it to an Azure storage account.

Happy to discuss wording and general approach. Hope it's of use.

Disclaimer: I had some problems running the repo to test locally, so I've only been able to check via .md preview in VS Code.

Add publish to azure blog post

dougajmcdonald · 2018-10-07T16:04:04Z

I'm not sure quite why this fails the tests from just cloning and adding some .md, any thoughts?

amberleyromo · 2018-10-08T17:41:52Z

Re: the tests question-- @DSchau @pieh?

Re: the repo running locally -- what kind of trouble are you having?

Re: the PR -- anyone have experience with Azure that can read through this? (@jlengstorf?)

pieh · 2018-10-08T17:49:53Z

I'm not sure quite why this fails the tests from just cloning and adding some .md, any thoughts?

The 2 tests that are failing are on windows and it's test problem and not functionality problem, please ignore them (at least for any docs/blog/content PRs)

pieh · 2018-10-08T17:51:46Z

docs/blog/author.yaml

@@ -169,3 +169,7 @@
  avatar: avatars/nader-dabit.jpg
  twitter: "@dabit3"
  bio: Developer Advocate at AWS
+- id: Doug McDonald
+  avatar: avatars/doug-mcdonald.jpg


avatar image is .png not `.jpg. Both formats are supported, but path need to be correct ;)

Arg! Sorry on the case!

dougajmcdonald · 2018-10-08T19:10:34Z

@amberleyromo with respect to running the repo locally, it seems to build OK (after a long time) but when I run the website I get a bunch of console errors. I can add them in here or open an issue, if that's neater, which would you rather?

EDIT OK, this is pretty weird, I've just run it again locally and it seemed to work this time :s also, the steps for generating thumbnails etc ran through in ~120 seconds rather than the 30-40 minutes it took last time. I do still get a warning, but the site loaded OK so happy to leave it like that!

Warning: Invalid DOM property `fill-rule`. Did you mean `fillRule`?
    in path (created by BlogPostTemplate)
    in svg (created by BlogPostTemplate)
    in a (created by BlogPostTemplate)
    in h2 (created by BlogPostTemplate)
    in div (created by BlogPostTemplate)
    in section (at template-blog-post.js:237)
  ...

dougajmcdonald · 2018-10-08T19:22:34Z

@pieh after updating the image url the checks seemed to complete, Touch wood after the last push if I give it time all will be well!

pieh · 2018-10-08T20:57:06Z

EDIT OK, this is pretty weird, I've just run it again locally and it seemed to work this time :s also, the steps for generating thumbnails etc ran through in ~120 seconds rather than the 30-40 minutes it took last time.

That's because images are already processed from previous build :)

pieh · 2018-10-08T21:40:57Z

I can't comment on actual content because I have absolutely no context on azure, but if it wasn't using vscode, but more general tool (CLI?) this would be great docs material I think

dougajmcdonald · 2018-10-09T05:47:30Z

@pieh I did in the first instance want to base it more around the azure CLI but ran into some problems where azure automated deployment doesn't play nicely with the need to run gatsby build and point to a build folder.

I did write an article on my own blog using github to deploy a site such as gatsby or CRA (which require a build) but it ended up using wercker (not a bad thing) and would be a longer read. Happy to try and convert that over if you'd like.

amberleyromo · 2018-10-09T16:18:33Z

@pieh shannon had recommended that this be a blog post, instead of docs material. I can add it to a list of things to ask her about when she gets back, if you feel it should be a doc!

docs/blog/2018-10-06-deploying-gatsby-to-azure/index.md

jlengstorf

Overall, this is a great tutorial, @dougajmcdonald! I just went through it and made comments for things that surprised me or didn't line up with the tutorial.

Really great work here. Thanks for putting this together!

docs/blog/2018-10-06-deploying-gatsby-to-azure/index.md

dougajmcdonald · 2018-10-11T19:01:55Z

@jlengstorf I've updated with the requested changes and thanks very much for the feedback, really useful.

I'd love to write something a bit less VS Code extension dependent, so will look into that next once I've got this one out of the way. Wanted to start as simple as possible!

docs/blog/2018-10-06-deploying-gatsby-to-azure/index.md

jlengstorf · 2018-10-12T01:11:40Z

@dougajmcdonald Great! A couple more minor changes, and then it's got my seal of approval. I'll let @amberleyromo make the final call to merge, and I think we'll need to work this into our content calendar as well (cc @lindaleebumblebee).

Todo before merging:

Fix the remaining couple issues
Choose a launch date
Update the blog meta to match the launch date

dougajmcdonald · 2018-10-12T07:13:51Z

@dougajmcdonald Great! A couple more minor changes, and then it's got my seal of approval. I'll let @amberleyromo make the final call to merge, and I think we'll need to work this into our content calendar as well (cc @lindaleebumblebee).

Todo before merging:

Fix the remaining couple issues

Choose a launch date *

Update the blog meta to match the launch date *

I've suggested a launch date of the 15th (Monday) and updated the meta to match. I'm guessing your team might want some say in this though, so let me know if you have something else in mind.

jlengstorf · 2018-10-13T00:23:12Z

@pieh the blog author validation is failing PNGs for avatars. Is that intentional?

pieh · 2018-10-13T00:25:39Z

@pieh the blog author validation is failing PNGs for avatars. Is that intentional?

Agh, I forgot about adding all the supported formats (TBF I wasn't sure if that's just all formats that sharp support), this can be changed here https://github.com/gatsbyjs/peril-gatsbyjs/blob/5eb2e5fb6dd05b0886264191a04ae87b3502e667/rules/validate-yaml.ts#L6

jlengstorf · 2018-10-13T00:33:04Z

Cool. Created gatsbyjs/peril-gatsbyjs#49 to track that. Will ignore the warning for now.

@dougajmcdonald this all looks great — @lindaleebumblebee and @amberleyromo will make final adjustments to the date for publishing and merge on the date they choose. We'll tag you on Twitter when it goes live as well.

Thanks again!

dougajmcdonald · 2018-10-14T16:37:59Z

Many thanks @jlengstorf I'm really happy to be able to contribute and will aim to do more in the future.

amberleyromo · 2018-10-16T15:18:51Z

Thanks @dougajmcdonald! Looks good to me -- thanks all for reviewing. I'll coordinate with @lindaleebumblebee.

gatsbot · 2018-11-05T18:06:08Z

Holy buckets, @dougajmcdonald — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

* 'master' of github.com:gatsbyjs/gatsby: (63 commits) Update how-to-contribute.md to mention the style guide when writing blogs/tutorials (gatsbyjs#9742) Added Tylermcginnis website (gatsbyjs#9619) Fix grammar and punctuation (gatsbyjs#9498) Fix typo of plugin authoring (gatsbyjs#9737) Authentication tutorial - small fixes (gatsbyjs#9738) chore: move run-sift (gatsbyjs#9549) docs: fix minor typo (gatsbyjs#9730) chore(release): Publish fix(gatsby-plugin-page-creator): ensure that __tests__ directory is actually ignored (gatsbyjs#9720) fix: revert admin redirect (gatsbyjs#9728) fix: adjust page order to make nested matchPaths work (gatsbyjs#9719) feat(gatsby-plugin-sharp): cache base64 if possible (gatsbyjs#9059) chore(release): Publish fix(gatsby-plugin-offline): Serve the offline shell for short URLs + use no-cors for external resources (gatsbyjs#9679) chore(release): Publish fix: ensure babel-preset-gatsby can be used with unit tests (gatsbyjs#9629) feat(www): Filter posts by date (gatsbyjs#9400) fix(blog): azure blog post url date (gatsbyjs#9718) feat(blog): Add post on publishing to Azure (gatsbyjs#8868) Emphasize importance of promise return on source-plugin docs (gatsbyjs#9650) ...

* add author and avatar * add most of the tutorial content * Rework article to use azure storage * correct avatar img path * fix internal link * Fix link and text, add reference to using CC to verify identity * update links to show both vscode gallery and vscode extension * refer to endpoint in a more generic way * Add detail around the sign in process to Azure via VS Code * update wording * Removed direct extension link * Clean up final sentence * Update potential release date * fix: grammar * Update publish date

dougajmcdonald added 4 commits October 6, 2018 10:14

add author and avatar

272c0aa

add most of the tutorial content

150b54e

Rework article to use azure storage

aa96e80

Merge pull request #1 from dougajmcdonald/add-publish-to-azure-blog-post

5f07001

Add publish to azure blog post

dougajmcdonald requested a review from a team October 6, 2018 16:22

amberleyromo self-assigned this Oct 8, 2018

pieh reviewed Oct 8, 2018

View reviewed changes

correct avatar img path

679b267

fix internal link

f6e8d4a

DSchau reviewed Oct 10, 2018

View reviewed changes

docs/blog/2018-10-06-deploying-gatsby-to-azure/index.md Show resolved Hide resolved

jlengstorf suggested changes Oct 11, 2018

View reviewed changes

dougajmcdonald added 5 commits October 11, 2018 19:26

Fix link and text, add reference to using CC to verify identity

22cad44

update links to show both vscode gallery and vscode extension

d03a912

refer to endpoint in a more generic way

b9cf020

Add detail around the sign in process to Azure via VS Code

886fbcd

update wording

663a570

jlengstorf reviewed Oct 12, 2018

View reviewed changes

docs/blog/2018-10-06-deploying-gatsby-to-azure/index.md Outdated Show resolved Hide resolved

jlengstorf reviewed Oct 12, 2018

View reviewed changes

docs/blog/2018-10-06-deploying-gatsby-to-azure/index.md Outdated Show resolved Hide resolved

Removed direct extension link

6881a29

dougajmcdonald added 2 commits October 12, 2018 08:00

Clean up final sentence

84ecbc9

Update potential release date

cb42620

fix: grammar

fcb194a

jlengstorf approved these changes Oct 24, 2018

View reviewed changes

dougajmcdonald and others added 2 commits October 28, 2018 17:47

Merge branch 'master' into master

fa3a4fc

Update publish date

2282dc5

amberleyromo approved these changes Nov 5, 2018

View reviewed changes

amberleyromo merged commit 13cc55c into gatsbyjs:master Nov 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add blog post to publish to Azure #8868

Add blog post to publish to Azure #8868

dougajmcdonald commented Oct 6, 2018 •

edited

dougajmcdonald commented Oct 7, 2018

amberleyromo commented Oct 8, 2018

pieh commented Oct 8, 2018

pieh Oct 8, 2018

dougajmcdonald Oct 8, 2018

dougajmcdonald commented Oct 8, 2018 •

edited

dougajmcdonald commented Oct 8, 2018

pieh commented Oct 8, 2018

pieh commented Oct 8, 2018

dougajmcdonald commented Oct 9, 2018

amberleyromo commented Oct 9, 2018

jlengstorf left a comment

dougajmcdonald commented Oct 11, 2018

jlengstorf commented Oct 12, 2018

dougajmcdonald commented Oct 12, 2018

jlengstorf commented Oct 13, 2018

pieh commented Oct 13, 2018

jlengstorf commented Oct 13, 2018

dougajmcdonald commented Oct 14, 2018

amberleyromo commented Oct 16, 2018

gatsbot bot commented Nov 5, 2018

Add blog post to publish to Azure #8868

Add blog post to publish to Azure #8868

Conversation

dougajmcdonald commented Oct 6, 2018 • edited

dougajmcdonald commented Oct 7, 2018

amberleyromo commented Oct 8, 2018

pieh commented Oct 8, 2018

pieh Oct 8, 2018

Choose a reason for hiding this comment

dougajmcdonald Oct 8, 2018

Choose a reason for hiding this comment

dougajmcdonald commented Oct 8, 2018 • edited

dougajmcdonald commented Oct 8, 2018

pieh commented Oct 8, 2018

pieh commented Oct 8, 2018

dougajmcdonald commented Oct 9, 2018

amberleyromo commented Oct 9, 2018

jlengstorf left a comment

Choose a reason for hiding this comment

dougajmcdonald commented Oct 11, 2018

jlengstorf commented Oct 12, 2018

dougajmcdonald commented Oct 12, 2018

jlengstorf commented Oct 13, 2018

pieh commented Oct 13, 2018

jlengstorf commented Oct 13, 2018

dougajmcdonald commented Oct 14, 2018

amberleyromo commented Oct 16, 2018

gatsbot bot commented Nov 5, 2018

dougajmcdonald commented Oct 6, 2018 •

edited

dougajmcdonald commented Oct 8, 2018 •

edited