Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Remove react-hot-loader/patch entry #9695

Merged
merged 1 commit into from Nov 9, 2018
Merged

chore(gatsby): Remove react-hot-loader/patch entry #9695

merged 1 commit into from Nov 9, 2018

Conversation

alexandernanberg
Copy link
Contributor

The patch entry should no longer be necessary (after v4 I think), so I should be safe to remove it.

https://github.com/gaearon/react-hot-loader#no-patch-required

@alexandernanberg alexandernanberg requested a review from a team as a code owner November 4, 2018 19:08
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Would you be able to validate this locally and ensure hot reloading still works as intended?

Otherwise I can get to this later today and validate, as well!

@alexandernanberg
Copy link
Contributor Author

Hmm I have a weird issue with gatsby-dev-cli – after I run gatsby-dev the permissions of the moved files change and I can't execute them.

So when running yarn develop I get this error

yarn run v1.12.1
$ gatsby develop
/bin/sh: /Users/alna/dev/gatsby-starter-default/node_modules/.bin/gatsby: Permission denied
error Command failed with exit code 126.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Anyway, works when I set the correct permission manually with chmod.

In my tests it looks like react-hot-loader isn't working without this change either. Because if I add a stateful component the state should persist when I make changes to the file – right?

@alexandernanberg
Copy link
Contributor Author

@DSchau Okay, so I can confirm that this works exactly the same way as before on my machine using gatsby-dev. So this should be safe to merge

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pieh pieh merged commit 1858365 into gatsbyjs:master Nov 9, 2018
@alexandernanberg alexandernanberg deleted the chore/remove-react-hot-loader-patch branch November 10, 2018 05:47
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…#9695)

The patch entry should no longer be necessary (after v4 I think), so I should be safe to remove it.

https://github.com/gaearon/react-hot-loader#no-patch-required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants