Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove special layouts from v2 #2

Merged
merged 7 commits into from May 4, 2018
Merged

RFC: Remove special layouts from v2 #2

merged 7 commits into from May 4, 2018

Conversation

@KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Apr 6, 2018

Read formatted version

@KyleAMathews
Copy link
Contributor Author

@KyleAMathews KyleAMathews commented Apr 23, 2018

This RFC has entered the final comment period.

@KyleAMathews
Copy link
Contributor Author

@KyleAMathews KyleAMathews commented Apr 23, 2018

I merged a PR implementing this into v2, in the process upgrading a number of sites — check it out! gatsbyjs/gatsby#4887

@sqrtroot
Copy link

@sqrtroot sqrtroot commented Apr 23, 2018

Maybe the Context Api is something that could be considered for passing down these static queries all troughout the application? This would allow getting this page data without passing props around trough the whole app.

@KyleAMathews
Copy link
Contributor Author

@KyleAMathews KyleAMathews commented Apr 24, 2018

Yeah! I ended up using context for loading the data in development — in production, the babel plugin adds an import directly the query result so webpack handles bundling the component query result.

@KyleAMathews
Copy link
Contributor Author

@KyleAMathews KyleAMathews commented May 4, 2018

The PR has now been implemented and quite a few sites upgraded and everything seems 👌so merging!

@KyleAMathews KyleAMathews merged commit 59fa73c into master May 4, 2018
@KyleAMathews KyleAMathews deleted the remove-layouts branch May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.