Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerce the input given to the transports to charlists #66

Closed
gausby opened this issue Aug 10, 2018 · 1 comment
Closed

Coerce the input given to the transports to charlists #66

gausby opened this issue Aug 10, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@gausby
Copy link
Owner

gausby commented Aug 10, 2018

The transports expect charlists as input for some keys; I think it would improve usability of the transport if it was possible to pass in binaries/stings, and let the init coerce the input to charlists where charlists are expected.
@gausby gausby added the enhancement New feature or request label Aug 10, 2018
@voltone
Copy link
Contributor

voltone commented Aug 11, 2018

This is definitely needed for the hostname, but it actually looks like :ssl can handle paths as binary strings. Not sure this was always the case...

@gausby gausby mentioned this issue Aug 19, 2018
Merged
@gausby gausby closed this as completed in 5caccaa Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gausby @voltone