Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #159 #162

Merged
merged 5 commits into from Aug 12, 2019

Conversation

@anirudnits
Copy link

commented Aug 10, 2019

Fixed the imports of the files in /socli directory by adding the file directory in sys.path using
BASE_DIR = os.path.dirname(os.path.realpath(__file__))
sys.path = [BASE_DIR] + sys.path
. Now it works for both versions python2 and python3


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

anirudnits added some commits Aug 9, 2019

Fixed the imports of the files in /socli directory by adding the file…
… directory in sys.path. Now it works for both versions python2 and python3
@gautamkrishnar
Copy link
Owner

left a comment

@anirudnits please remove .vscode directory.

@gautamkrishnar gautamkrishnar self-assigned this Aug 10, 2019

@anirudnits

This comment has been minimized.

Copy link
Author

commented Aug 10, 2019

@gautamkrishnar gautamkrishnar changed the base branch from refactoring to fix/py-versions Aug 12, 2019

@gautamkrishnar
Copy link
Owner

left a comment

LGTM 👍

@gautamkrishnar gautamkrishnar merged commit 79f128b into gautamkrishnar:fix/py-versions Aug 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gautamkrishnar

This comment has been minimized.

Copy link
Owner

commented Aug 12, 2019

@anirudnits thanks a lot for the fix. Will test it out and merge to the main branch soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.