princurve 2.0.2

[rcannood]

Hello Gavin @gavinsimpson,

princurve 2.0.2 was just pushed to CRAN. I notice your package uses princurve and wish to notify you of the changes so you can update your package accordingly.

I believe what is relevant for you is that get.lam has been renamed to project_to_curve, in order to match the name of the function better with what its purpose is. In addition, the input argument and output variable tag has been renamed to ord.

The function get.lam still exists in the package, for now, as not to break analogue, but get.lam will be deprecated on July 1st and later on removed.

If you have any remarks or questions, feel free to let me know!
Robrecht

[gavinsimpson]

Dear Robrecht, Thanks for letting me know; I'll prepare some updates to analogue. I'm unlikely to have analogue ready to submit to CRAN before August as I am travelling a lot this summer for work and vacation. Will something change on CRAN as of July 1st that will result in analogue failing checks - I will be out of the office for a month from June 30th so if there's going to be a problem with CRAN I can be a bit more proactive or spend some of my flight time getting the in devel version of analogue ready to go. All the best and thanks for maintaining the package - I know that it had been orphaned some years back but I wasn't in a position to take on further coding activities at the time! All the best Gavin

…

On Tue, 12 Jun 2018 at 10:52, Robrecht Cannoodt ***@***.***> wrote: Hello Gavin @gavinsimpson <https://github.com/gavinsimpson>, princurve 2.0.2 <https://cran.r-project.org/web/packages/princurve/index.html> was just pushed to CRAN. I notice your package uses princurve and wish to notify you of the changes so you can update your package accordingly. I believe what is relevant for you is that get.lam has been renamed to project_to_curve, in order to match the name of the function better with what its purpose is. In addition, the input argument and output variable tag has been renamed to ord. The function get.lam still exists in the package, for now, as not to break analogue, but get.lam will be deprecated on July 1st and later on removed. If you have any remarks or questions, feel free to let me know! Robrecht — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfaiEwC_rboAOkPcfsqrPNTs9AAghuIks5t7_HFgaJpZM4Uky-8> .

-- Gavin Simpson, PhD

[jarioksa]

There are but a couple of places where the get.lam() function name needs to be changed. It seems there is more work in fixing & debugging the tag -> ord change.

[rcannood]

I think the changes will indeed be fairly minimal. It's just substituting get.lam with project_to_curve, and tag with ord. If you like, I can create a pull request for analogue with what I think needs to be changed.

Are there any features you would like to see in princurve?

[rcannood]

Hello @gavinsimpson and @jarioksa,

I wish to move forward with deprecating principal.curve and get.lam. Did you already have time to take a look at this? I have proposed changes in PR #21 which would make analogue work with future versions of princurve.

Kind regards,
Robrecht

[rcannood]

Hello @gavinsimpson and @jarioksa,

principal.curve() and get.lam() have both been fully deprecated starting from princurve 2.1.3. Since 2.1.3 is on its way to CRAN, analogue will be generating deprecation warnings.

Robrecht

[gavinsimpson]

Thanks @rcannood I got the email from CRAN this morning about the change. I'll be dealing with this later in the week.

[gavinsimpson]

This is now fixed and is on CRAN. Thanks @rcannood