Skip to content

/ gratia

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrappers to smoothCon so that it is easy to visualise basis functions #42

Closed
gavinsimpson opened this issue May 28, 2019 · 1 comment
Closed

Add wrappers to smoothCon so that it is easy to visualise basis functions #42

gavinsimpson opened this issue May 28, 2019 · 1 comment
Labels
enhancement
Milestone
0.3

Comments

@gavinsimpson
Copy link
Owner

@gavinsimpson gavinsimpson commented May 28, 2019 •
edited

It would be useful for teaching and understanding GAMs if you could quickly and intuitively generate a basis expansion for a covariate, evaluate it at some values producing a tidy object and then plot it with draw() or ggplot().
@gavinsimpson gavinsimpson changed the title Add wrappers to smoothCon and predictMatrix so that it is easy to visualise basis functions Add wrappers to smoothCon and PredictMat so that it is easy to visualise basis functions Sep 10, 2019
gavinsimpson added a commit that referenced this issue Sep 11, 2019
@gavinsimpson
add function basis() as per #42
568b3f5
gavinsimpson added a commit that referenced this issue Sep 12, 2019
@gavinsimpson
Merge branch 'issue-42'; initial code to address enhancement in #42.
Loading status checks…
540af2e 
Adds basic basis generation and plotting. Need to check bivariate
and tensor product smooths work and do more testing.
@gavinsimpson gavinsimpson changed the title Add wrappers to smoothCon and PredictMat so that it is easy to visualise basis functions Add wrappers to smoothCon so that it is easy to visualise basis functions Sep 19, 2019
@gavinsimpson
Copy link
Owner Author

@gavinsimpson gavinsimpson commented Sep 19, 2019

This doesn't involve PredictMat(). The basic functionality is now added. Need some testing and draw() methods for 2d and more specialised bases as needed.
@gavinsimpson gavinsimpson added this to the 0.3 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.3
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@gavinsimpson
You can’t perform that action at this time.