Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the derivatives() & related functions failing under R-devel #64

Closed
gavinsimpson opened this issue Mar 3, 2020 · 1 comment
Closed

Comments

@gavinsimpson
Copy link
Owner

@gavinsimpson gavinsimpson commented Mar 3, 2020

This seems to be related to the change to stringsAsFactors = FALSE and is affecting 6 tests in `test-derivatives.R:

E  Running 'test-all.R' [95s] (1m 29.2s)
   Running the tests in 'tests/test-all.R' failed.
   Last 13 lines of output:
      6. gratia:::central_finite_diff2(mod, df)
      8. base::Ops.data.frame(result, h)
      7. gratia:::shift_values(newdata, h = h, i = ind, FUN = "+")
     
     == testthat results  ===========================================================
     [ OK: 770 | SKIPPED: 77 | WARNINGS: 0 | FAILED: 6 ]
     1. Failure: internal finite diff functions fail for all factor vars (@test-derivatives.R#270) 
     2. Failure: internal finite diff functions fail for all factor vars (@test-derivatives.R#274) 
     3. Failure: internal finite diff functions fail for all factor vars (@test-derivatives.R#278) 
     4. Failure: internal finite diff functions fail for all factor vars (@test-derivatives.R#282) 
     5. Failure: internal finite diff functions fail for all factor vars (@test-derivatives.R#286) 
     6. Failure: internal finite diff functions fail for all factor vars (@test-derivatives.R#290) 
     
     Error: testthat unit tests failed
@gavinsimpson
Copy link
Owner Author

@gavinsimpson gavinsimpson commented Mar 3, 2020

See #61 for further issues related

gavinsimpson added a commit that referenced this issue Mar 3, 2020
gavinsimpson added a commit that referenced this issue Mar 3, 2020
gavinsimpson added a commit that referenced this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.