Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

pyquery.test.TestWebScrapping failure #17

Closed
idella opened this Issue · 6 comments

2 participants

@idella

Source compiled.

  • Testing of dev-python/pyquery-1.2.4 with CPython 3.2... PYTHONPATH=build-3.2/lib nosetests --verbosity=1 ..........................................................................F...........F......

FAIL: test_post (pyquery.test.TestWebScrapping)

Traceback (most recent call last):
File "/mnt/gen2/TmpDir/portage/dev-python/pyquery-1.2.4/work/pyquery-1.2.4/pyquery/test.py", line 574, in test_post
self.assertEqual(d('input[name=q]:last').val(), 'foo')
AssertionError: None != 'foo'


Ran 93 tests in 8.419s

also

  • Testing of dev-python/pyquery-1.2.4 with CPython 2.7... PYTHONPATH=build-2.7/lib nosetests --verbosity=1 .............................................................................F...........F......

pyquery- version 1.2.4
pyquery # python -V Python 2.7.3; Python 3.2.3

@gawel
Owner

I've fixed a few tests some days ago. All are green: https://travis-ci.org/gawel/pyquery

@idella

I see. Was this

Source compiled.

  • Testing of dev-python/pyquery-1.2.4 with CPython 2.7... PYTHONPATH=build-2.7/lib nosetests --verbosity=1 .............................................................................F...........F......

FAIL: Doctest:

Traceback (most recent call last):
File "/usr/lib64/python2.7/doctest.py", line 2201, in runTest
raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for
File "/var/tmp/portage/portage/dev-python/pyquery-1.2.4/work/pyquery-1.2.4/docs/tips.txt", line 0


File "/var/tmp/portage/portage/dev-python/pyquery-1.2.4/work/pyquery-1.2.4/docs/tips.txt", line 10, in
Failed example:
d('a[tabindex="-1"]').attr('href')
Expected:
'/about.html'
Got:

'/about'

File "/var/tmp/portage/portage/dev-python/pyquery-1.2.4/work/pyquery-1.2.4/docs/tips.txt", line 14, in
Failed example:
d('a[tabindex="-1"]').attr('href')
Expected:
'http://duckduckgo.com/about.html'
Got:
'http://duckduckgo.com/about'

one of them? Some fixes implies some corresponding patches in corresponding commits.

@gawel
Owner

Yup. Both of them. 194a09f

I can make a release if you need one.

@gawel
Owner

And you should use tox to run tests ;)

@idella

ah good; Once patched, that's fine really. Not fussed about a release, the patch will just be dropped when it comes.

"And you should use tox to run tests ;)"

Beware the tyranny of the should. We could run tox, but it 'shouldn't go downloading the very same package it's charged to be testing intra source code, thereby cracking gentoo fundamental policy right down the middle.
You're at liberty to design the setup.py and invocation of the test suite.
The gentoo makers used their liberty to make a policy to 'ban' any downloading mid build.
An n'er the twain shall meet.

Patch works fine thanks

@gawel
Owner

Ok. Fine. I'm closing the issue then

@gawel gawel closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.