Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdf from path helper #233

Merged
merged 3 commits into from Mar 9, 2022
Merged

Sdf from path helper #233

merged 3 commits into from Mar 9, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 18, 2022

🎉 New feature

Summary

This PR adds a helper function that return the SDF file associated with a Fuel resource. This is useful for downstream users of Fuel resources that want to parse the SDF file for a model or world.

Test it

Run the tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig added 2 commits February 18, 2022 12:18
…r world

Signed-off-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Feb 18, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 18, 2022
Core development automation moved this from Inbox to In review Mar 1, 2022
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig enabled auto-merge (squash) March 9, 2022 19:43
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #233 (089218a) into ign-fuel-tools7 (d590c81) will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools7     #233      +/-   ##
===================================================
+ Coverage            75.39%   75.44%   +0.04%     
===================================================
  Files                   20       20              
  Lines                 2829     2859      +30     
===================================================
+ Hits                  2133     2157      +24     
- Misses                 696      702       +6     
Impacted Files Coverage Δ
src/Interface.cc 83.92% <80.00%> (-4.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d590c81...089218a. Read the comment docs.

@nkoenig nkoenig merged commit 2a1758c into ign-fuel-tools7 Mar 9, 2022
Core development automation moved this from In review to Done Mar 9, 2022
@nkoenig nkoenig deleted the sdf_from_path_helper branch March 9, 2022 20:01
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants