Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace color and pose for GridConfig with GzColor and GzPose #463

Merged
merged 5 commits into from Aug 17, 2022

Conversation

AzulRadio
Copy link
Contributor

Signed-off-by: youhy haoyuan2019@outlook.com

New feature

Summary

As title. The behavior should be exactly the same as before.

gridconfig_replace_demo

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: youhy <haoyuan2019@outlook.com>
Signed-off-by: youhy <haoyuan2019@outlook.com>
@AzulRadio AzulRadio added the OOBE 📦✨ Out-of-box experience label Aug 10, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Aug 10, 2022
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #463 (8034a7a) into ign-gui6 (eef3853) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 8034a7a differs from pull request most recent head 89a9ccb. Consider uploading reports for the commit 89a9ccb to get more accurate results

@@             Coverage Diff              @@
##           ign-gui6     #463      +/-   ##
============================================
+ Coverage     67.97%   68.00%   +0.03%     
============================================
  Files            39       39              
  Lines          5239     5239              
============================================
+ Hits           3561     3563       +2     
+ Misses         1678     1676       -2     
Impacted Files Coverage Δ
src/plugins/scene3d/Scene3D.cc 49.87% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AzulRadio AzulRadio changed the title Replace color for GridConfig with GzColor Replace color and pose for GridConfig with GzColor and GzPose Aug 10, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Aug 10, 2022
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

src/plugins/grid_config/GridConfig.qml Outdated Show resolved Hide resolved
src/plugins/grid_config/GridConfig.qml Outdated Show resolved Hide resolved
src/plugins/grid_config/GridConfig.qml Outdated Show resolved Hide resolved
src/plugins/grid_config/GridConfig.qml Outdated Show resolved Hide resolved
AzulRadio and others added 2 commits August 11, 2022 12:47
Signed-off-by: youhy <haoyuan2019@outlook.com>
@jennuine jennuine merged commit 27c2634 into ign-gui6 Aug 17, 2022
Core development automation moved this from In review to Done Aug 17, 2022
@jennuine jennuine deleted the azulradio/gridconfig_commonwidget branch August 17, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants