Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluid added mass to inertial #459

Merged
merged 11 commits into from
Jul 28, 2022
Merged

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jul 11, 2022

🎉 New feature

Summary

Added fluid added mass support to the inertial class, as described on the Fluid Added Mass Proposal.

I also had to add addition operators to Matrix6, because I forgot the one API I needed when I created the class in #455 🤦🏽

Test it

Take a look at the new tests.

TODO

  • The current implementation doesn't take into account the inertial pose's orientation. I think this may be a mistake. I'm going to revisit this as I open downstream PRs.
  • Python bindings

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jul 11, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jul 11, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 11, 2022
@chapulina chapulina moved this from Inbox to In progress in Core development Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #459 (2ad032f) into main (155059b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          75       75           
  Lines        6863     6887   +24     
=======================================
+ Hits         6842     6866   +24     
  Misses         21       21           
Impacted Files Coverage Δ
include/gz/math/Inertial.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155059b...2ad032f. Read the comment docs.

include/gz/math/Inertial.hh Show resolved Hide resolved
include/gz/math/Inertial.hh Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
include/gz/math/Inertial.hh Outdated Show resolved Hide resolved
include/gz/math/Inertial.hh Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
include/gz/math/Inertial.hh Outdated Show resolved Hide resolved
include/gz/math/Inertial.hh Show resolved Hide resolved
include/gz/math/Inertial.hh Outdated Show resolved Hide resolved
include/gz/math/Inertial.hh Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
src/Inertial_TEST.cc Outdated Show resolved Hide resolved
src/Inertial_TEST.cc Outdated Show resolved Hide resolved
@chapulina chapulina added Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request labels Jul 25, 2022
@chapulina chapulina self-assigned this Jul 25, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina moved this from In progress to In review in Core development Jul 27, 2022
@chapulina chapulina marked this pull request as ready for review July 27, 2022 23:22
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clarified one of the new test comments in 2ad032f and from there it looks good to me!

@chapulina chapulina merged commit b9ae648 into main Jul 28, 2022
Core development automation moved this from In review to Done Jul 28, 2022
@chapulina chapulina deleted the chapulina/7/fluid_added_mass branch July 28, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change Breaks API, ABI or behavior. Must target unstable version. enhancement New feature or request 🌱 garden Ignition Garden MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants