Add fluid added mass to inertial #271
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
the
MBARI-LRAUV
Codecov Report
@@ Coverage Diff @@
## main #271 +/- ##
==========================================
+ Coverage 84.62% 84.96% +0.33%
==========================================
Files 10 10
Lines 995 1024 +29
==========================================
+ Hits 842 870 +28
- Misses 153 154 +1
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
the
needs upstream release
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
MBARI buoy
chapulina
added
the
Breaking change
chapulina
removed
the
needs upstream release
| /// 22, 23, 24, 25, | ||
| /// 33, 34, 35, | ||
| /// 44, 45, | ||
| /// 55, |
There was a problem hiding this comment.
this doesn't explicitly say how these values are packed into the repeated double vector. From looking at the test, I believe they are packed from left to right starting with the top row, then working down, like [00, ... 05, 11, ... 15, 22, ... 25, 33, ... 35, 44, 45, 55]
There was a problem hiding this comment.
What's throwing you off, the spacing? The elements are listed in that order exactly
There was a problem hiding this comment.
it looks like you are labeling the elements according to their place in the matrix, not listing the order in which they are placed in the vector
There was a problem hiding this comment.
it looks like the upper triangle of a matrix to me, not a vector
There was a problem hiding this comment.
Can you suggest the wording that would work for you? Maybe mentioning that the indices are row-first and instead of organized as follows say ordered as follows? Or something completely different?
There was a problem hiding this comment.
it looks like the upper triangle of a matrix to me, not a vector
It's both! That's what I was going for at least...
There was a problem hiding this comment.
I guess it looks like a matrix to me and the indices are matrix indices, whereas vector indices would just be integers from [0..20]
0, 1, 2, 3, 4, 5,
6, 7, 8, 9, 10,
11, 12, 13, 14,
15, 16, 17,
18, 19,
20,
🎉 New feature
Summary
Added fluid added mass support to the inertial message.
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸