Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project() to examples #322

Merged
merged 1 commit into from Jan 7, 2022
Merged

Conversation

chapulina
Copy link
Contributor

๐ŸฆŸ Bug fix

Summary

This should fix CMake warnings that are turning the Jenkins build yellow since we migrated to Focal in gazebo-tooling/release-tools#565

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ๐Ÿ”ธ

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@osrf-triage osrf-triage added this to Inbox in Core development Jan 6, 2022
@github-actions github-actions bot added the ๐Ÿฏ fortress Ignition Fortress label Jan 6, 2022
@chapulina chapulina changed the base branch from ign-physics5 to ign-physics2 January 6, 2022 22:03
@chapulina chapulina added ๐Ÿฐ citadel Ignition Citadel and removed ๐Ÿฏ fortress Ignition Fortress labels Jan 6, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #322 (e88b651) into ign-physics2 (042e2c3) will decrease coverage by 5.27%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-physics2     #322      +/-   ##
================================================
- Coverage         82.84%   77.56%   -5.28%     
================================================
  Files               108      129      +21     
  Lines              4243     7114    +2871     
================================================
+ Hits               3515     5518    +2003     
- Misses              728     1596     +868     
Impacted Files Coverage ฮ”
...nclude/ignition/physics/detail/RelativeQuantity.hh 95.36% <0.00%> (-4.64%) โฌ‡๏ธ
tpe/lib/src/Model.cc 95.41% <0.00%> (-2.97%) โฌ‡๏ธ
tpe/plugin/src/Base.hh 95.37% <0.00%> (-2.63%) โฌ‡๏ธ
dartsim/src/Base.hh 98.52% <0.00%> (-0.50%) โฌ‡๏ธ
tpe/lib/src/Shape.hh 100.00% <0.00%> (รธ)
dartsim/src/plugin.cc 100.00% <0.00%> (รธ)
dartsim/src/SimulationFeatures.hh 100.00% <0.00%> (รธ)
include/ignition/physics/Geometry.hh 100.00% <0.00%> (รธ)
include/ignition/physics/ForwardStep.hh 100.00% <0.00%> (รธ)
include/ignition/physics/detail/Joint.hh 100.00% <0.00%> (รธ)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 042e2c3...e88b651. Read the comment docs.

@chapulina chapulina merged commit bef599d into ign-physics2 Jan 7, 2022
Core development automation moved this from In review to Done Jan 7, 2022
@chapulina chapulina deleted the chapulina/2/cmake_warnings branch January 7, 2022 00:27
@j-rivero j-rivero removed this from Done in Core development May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿฐ citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants