Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sky #445

Merged
merged 7 commits into from
Dec 18, 2020
Merged

Add support for sky #445

merged 7 commits into from
Dec 18, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Nov 4, 2020

depends on:

Users can now enable a sky in the scene through the <sky> SDF element. It's currently only a static skybox background and sky properties like wind speed, humidity, etc are not supported yet. Only works in ogre2 rendering engine.

To test:

ign gazebo -v 4 sky.sdf

sky_ign-gazebo

Known issue:

Sky is not visible to an RGBD camera yet.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Nov 4, 2020
@iche033 iche033 added the needs upstream release Blocked by a release of an upstream library label Nov 4, 2020
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sunny! 🌞

Is there a plan to support Ogre 1 and the sky properties in the near future?

src/gui/plugins/scene3d/Scene3D.cc Show resolved Hide resolved
examples/worlds/sky.sdf Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Copy link
Contributor Author

iche033 commented Dec 1, 2020

Is there a plan to support Ogre 1 and the sky properties in the near future?

I think for ogre1, we can just port over the skyx code from gazebo classic. As for supporting other sky properties in ogre2, maybe we can see if it's possible to port the skyx implementation to ogre2.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Copy link
Contributor Author

iche033 commented Dec 18, 2020

sdformat 10.1.0 was released with sky DOM so I think we can merge this now.

@iche033 iche033 merged commit 0e6bd2a into main Dec 18, 2020
@iche033 iche033 deleted the sky branch December 18, 2020 05:37
@bperseghetti
Copy link
Member

Is there a plan to support Ogre 1 and the sky properties in the near future?

I think for ogre1, we can just port over the skyx code from gazebo classic. As for supporting other sky properties in ogre2, maybe we can see if it's possible to port the skyx implementation to ogre2.

@chapulina @iche033 Has anyone looked into this more, including possibly adding some skyx features like storms for ogre2? Having moving clouds back again instead of static skybox would be nice.

@chapulina
Copy link
Contributor

Has anyone looked into this more

I believe no one has looked into this yet, or has plans to look into it in the near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice needs upstream release Blocked by a release of an upstream library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants