Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fluid added mass to inertial #1077

Merged
merged 6 commits into from
Jul 28, 2022
Merged

Add fluid added mass to inertial #1077

merged 6 commits into from
Jul 28, 2022

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Summary

Implements the Fluid Added Mass Proposal.

Test it

See the added tests. I'll be opening downstream PRs next.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim label Jul 12, 2022
@osrf-triage osrf-triage added this to Inbox in Core development Jul 12, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jul 12, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@chapulina chapulina moved this from Inbox to In review in Core development Jul 12, 2022
sdf/1.10/inertial.sdf Outdated Show resolved Hide resolved
sdf/1.10/inertial.sdf Outdated Show resolved Hide resolved
sdf/1.10/inertial.sdf Outdated Show resolved Hide resolved
sdf/1.10/inertial.sdf Outdated Show resolved Hide resolved
sdf/1.10/inertial.sdf Outdated Show resolved Hide resolved
src/Link.cc Outdated Show resolved Hide resolved
src/Link.cc Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
sdf/1.10/inertial.sdf Outdated Show resolved Hide resolved
Copy link
Contributor

@quarkytale quarkytale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chapulina chapulina added enhancement New feature or request Breaking change Breaks API, ABI or behavior. Must target unstable version. and removed Breaking change Breaks API, ABI or behavior. Must target unstable version. labels Jul 23, 2022
@chapulina chapulina self-assigned this Jul 25, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jul 28, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) July 28, 2022 04:38
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1077 (24b8030) into main (3c93681) will increase coverage by 0.04%.
The diff coverage is 95.52%.

@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
+ Coverage   83.11%   83.16%   +0.04%     
==========================================
  Files         155      155              
  Lines       18783    18850      +67     
==========================================
+ Hits        15612    15676      +64     
- Misses       3171     3174       +3     
Impacted Files Coverage Δ
src/Link.cc 97.94% <95.52%> (-0.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c93681...24b8030. Read the comment docs.

@chapulina chapulina merged commit 23cb93a into main Jul 28, 2022
Core development automation moved this from In review to Done Jul 28, 2022
@chapulina chapulina deleted the chapulina/13/added_mass branch July 28, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🌱 garden Ignition Garden MBARI buoy Sponsored by MBARI buoy sim project: https://github.com/osrf/buoy_sim
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants