Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Added OpticalFrameID and SetOpticalFrameID to pyCamera #1184

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Oct 10, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Closes #1128

Summary

Python: Added OpticalFrameID and SetOpticalFrameID to pyCamera

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 10, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1184 (6694cd4) into sdf13 (ffea2ed) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 6694cd4 differs from pull request most recent head d28488c. Consider uploading reports for the commit d28488c to get more accurate results

@@            Coverage Diff             @@
##            sdf13    #1184      +/-   ##
==========================================
- Coverage   87.06%   87.05%   -0.01%     
==========================================
  Files         125      125              
  Lines       15983    15987       +4     
==========================================
+ Hits        13915    13917       +2     
- Misses       2068     2070       +2     
Impacted Files Coverage Δ
python/src/sdf/pyCamera.cc 57.01% <50.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 527fd38 into sdf13 Oct 20, 2022
@scpeters scpeters deleted the ahcorde/python/camera_optical_frame_id branch October 20, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add camera optical_frame_id element to Python
2 participants