Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdf12 to sdf13 #1200

Merged
merged 8 commits into from
Nov 16, 2022
Merged

sdf12 to sdf13 #1200

merged 8 commits into from
Nov 16, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Nov 16, 2022

➡️ Forward port

Port sdf12 to sdf13

Branch comparison: sdf13...sdf12

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

lopsided98 and others added 7 commits November 8, 2022 23:22
The CMAKE_INSTALL_*DIR variables may be absolute, in which case they must not
be concatenated with CMAKE_INSTALL_PREFIX. If an absolute path is needed,
CMAKE_INSTALL_FULL_*DIR must be used. In other cases, more complex logic may be
required to make packages relocatable in the case that CMAKE_INSTALL_*DIR is
relative.

This patch replaces the custom LIB_INSTALL_DIR and BIN_INSTALL_DIR variables
with the standard GNUInstallDirs variables throughout the code. The custom
variables are still honored if specified manually.

Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Added camera info topic to Camera
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from azeey as a code owner November 16, 2022 12:09
@ahcorde ahcorde self-assigned this Nov 16, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 16, 2022
@ahcorde
Copy link
Collaborator Author

ahcorde commented Nov 16, 2022

Added camera_info_topic to 1.10 and Python interfaces

Signed-off-by: ahcorde <ahcorde@gmail.com>
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1200 (74fe572) into sdf13 (e79b4e0) will increase coverage by 0.00%.
The diff coverage is 88.23%.

@@           Coverage Diff           @@
##            sdf13    #1200   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         124      124           
  Lines       16079    16096   +17     
=======================================
+ Hits        14070    14085   +15     
- Misses       2009     2011    +2     
Impacted Files Coverage Δ
python/src/sdf/pyCamera.cc 56.89% <50.00%> (-0.13%) ⬇️
src/Camera.cc 89.29% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey merged commit d5b99a5 into sdf13 Nov 16, 2022
@azeey azeey deleted the ahcorde/sdf12_to_sdf13 branch November 16, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants