Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse URDF continuous joint effort/velocity limits #684

Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Sep 2, 2021

🦟 Bug fix

Fixes #683.

Summary

This fixes parsing of effort and velocity limits for continuous joints in URDF files. A failing test was added in scpeters@75e4226 and fixed in 33e4b4d.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Test currently fails.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Fixes gazebosim#683.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Sep 2, 2021
@scpeters scpeters changed the title Urdf continuous effort velocity limits Parse URDF continuous joint effort/velocity limits Sep 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #684 (33e4b4d) into sdf9 (d087d47) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             sdf9     #684      +/-   ##
==========================================
+ Coverage   86.84%   86.88%   +0.03%     
==========================================
  Files          62       62              
  Lines        9738     9734       -4     
==========================================
  Hits         8457     8457              
+ Misses       1281     1277       -4     
Impacted Files Coverage Δ
src/parser_urdf.cc 79.36% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d087d47...33e4b4d. Read the comment docs.

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@scpeters scpeters merged commit f180b39 into gazebosim:sdf9 Sep 4, 2021
@scpeters scpeters deleted the urdf_continuous_effort_velocity_limits branch September 4, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants