Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Camera Python interface #982

Merged
merged 4 commits into from
May 21, 2022
Merged

Added Camera Python interface #982

merged 4 commits into from
May 21, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 18, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added Camera Python interface

Test it

from sdformat import Camera

camera = Camera()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added scripting Scripting interfaces to Ignition mujoco labels Apr 18, 2022
@ahcorde ahcorde self-assigned this Apr 18, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 18, 2022
@ahcorde ahcorde mentioned this pull request Apr 18, 2022
62 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #982 (38ea7a7) into main (0494785) will not change coverage.
The diff coverage is n/a.

❗ Current head 38ea7a7 differs from pull request most recent head 7b92fa6. Consider uploading reports for the commit 7b92fa6 to get more accurate results

@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0494785...7b92fa6. Read the comment docs.

@ahcorde ahcorde marked this pull request as ready for review April 18, 2022 16:02
@ahcorde ahcorde mentioned this pull request Apr 18, 2022
8 tasks
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #982 (3d4d1ad) into main (8c35006) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #982   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c35006...3d4d1ad. Read the comment docs.

@ahcorde ahcorde merged commit 35249da into main May 21, 2022
@ahcorde ahcorde deleted the ahcorde/python/camera branch May 21, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants