Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential mistake on decoding z80 opcodes #1

Closed
teatime-dev opened this issue Feb 2, 2019 · 1 comment
Closed

potential mistake on decoding z80 opcodes #1

teatime-dev opened this issue Feb 2, 2019 · 1 comment

Comments

@teatime-dev
Copy link

@teatime-dev teatime-dev commented Feb 2, 2019

under unprefixed opcodes, under x=3,z=0,y=4, it says LD (0xFF00 + nn), A as the operation.
I'm quite new to emulation but I think it's meant to say +n and not +nn since it would overflow most of the time.
Other opcode guides say n instead of nn, although perhaps for archival purposes you want might to keep this unmodified, I suppose.

phire added a commit to phire/Kea that referenced this issue Mar 1, 2019
@phire
Copy link

@phire phire commented Mar 1, 2019

You know, I had forgotten that I had even released that file anywhere publicly.

I'm pretty sure you are correct, +nn makes no sense. I've fixed it "upstream"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants