Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bits-description table separations more visible #529

Closed
vizigr0u opened this issue Jan 3, 2024 · 5 comments
Closed

Make bits-description table separations more visible #529

vizigr0u opened this issue Jan 3, 2024 · 5 comments

Comments

@vizigr0u
Copy link
Contributor

vizigr0u commented Jan 3, 2024

The tables showing the bit layout can be a bit hard to read sometimes because of the low contrast and very thin lines separating each field.
e.g.
image
image

(Issue exists for every theme)

Example of what a higher contrast would look like on the navy skin:
image

(changing --table-border-color to hsl(210, 25%, 33%) from hsl(210, 25%, 13%))

@ISSOtm
Copy link
Member

ISSOtm commented Jan 3, 2024

Yeah, seems fair. Can you open a PR?

@vizigr0u
Copy link
Contributor Author

vizigr0u commented Jan 3, 2024

Yeah, seems fair. Can you open a PR?

I quickly searched the repo for --table-border-color and couldn't find it so I figured it would be much faster for someone with the setup on their machine

@ISSOtm
Copy link
Member

ISSOtm commented Jan 3, 2024

Yeah, those are provided by mdBook; those can be overridden (e.g. .ayu .bit-descrs) in custom/style.css.

@vizigr0u
Copy link
Contributor Author

vizigr0u commented Jan 3, 2024

gotcha, I will try to get the repo setup on my machine and I'll make a PR

@ISSOtm
Copy link
Member

ISSOtm commented Jan 4, 2024

Fixed by #531.

@ISSOtm ISSOtm closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants