Skip to content

Commit

Permalink
Specify deployment URL
Browse files Browse the repository at this point in the history 
This should make the sitemap work (#25)
  • Loading branch information
@ISSOtm
ISSOtm committed Aug 9, 2021
1 parent b90a850 commit 0c9b420
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions _config.yml
View file
Expand Up @@ -13,8 +13,8 @@ keywords:
- game dev
- assembly
- asm
baseurl: ""

This comment has been minimized.

Sign in to view

Copy link
@zemzelett

zemzelett Nov 30, 2021

Is the slash really necessary here? For local development this breaks the whole page as assets are served from "http://" instead of "http://localhost".

image

This comment has been minimized.

Sign in to view

Copy link
@ISSOtm

ISSOtm Dec 2, 2021

Author Member

IIRC it broke some links on the GitHub deployment. I don't have any trouble with this on my own local copy, I wonder what's different...

This comment has been minimized.

Sign in to view

Copy link
@zemzelett

zemzelett Dec 3, 2021

Ok, i see.

It's odd, that it breaks for me. I'm on Windows right now, i might try it on a Linux or Mac device to see if that's playing a role.

This comment has been minimized.

Sign in to view

Copy link
@zemzelett

zemzelett Dec 12, 2021

Just fyi: Today i cloned the repository on a Mac, installed all necessary tools and am encountering the same "problem".

Seeing the two changes you made just sparked another idea i might try sometime soon. I'll give feedback as soon as i tried that idea.

This comment has been minimized.

Sign in to view

Copy link
@ISSOtm

ISSOtm Feb 10, 2022

Author Member

Now I'm having the problem as well, lol.
url: ""
baseurl: "/"
url: "https://rgbds.gbdev.io"
logo: /assets/rgbds.png
twitter:
card: summary_large_image
Expand Down

0 comments on commit 0c9b420

Please sign in to comment.