Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::deque for free space #1323

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Use std::deque for free space #1323

merged 1 commit into from
Mar 1, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Mar 1, 2024

This was a very annoying struct to refactor -- it was being (ab)used for two different purposes, as the node in a doubly-linked list, but also as a vector entry for that node (with only the .next field actually initialized).

@Rangi42 Rangi42 added the refactoring This PR is intended to clean up code more than change functionality label Mar 1, 2024
@Rangi42 Rangi42 added this to the v0.7.1 milestone Mar 1, 2024
@Rangi42 Rangi42 requested a review from ISSOtm March 1, 2024 19:26
@Rangi42 Rangi42 merged commit 446fb07 into gbdev:master Mar 1, 2024
24 checks passed
@Rangi42 Rangi42 deleted the freespace branch March 1, 2024 21:21
@pinobatch
Copy link
Member

This PR contained a use-after-free that caused sections to overlap (#1350). Fixed in #1352.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This PR is intended to clean up code more than change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants