Conversation
AntonioND
force-pushed
the
relicense
branch
3 times, most recently
from
cb4d24d to
4bc8cc3
Compare
BenHetherington
approved these changes
Jan 26, 2018
Contributor
BenHetherington
left a comment
BenHetherington
left a comment
There was a problem hiding this comment.
Great to hear that progress has been made on this! The MIT licence sounds like a good choice to me, so RGBDS can be helpful for as many people and projects as possible 😊
src/asm/charmap.c
Outdated
| #include "asm/main.h" | ||
| #include "asm/output.h" | ||
|
|
||
| uint32_t decode(uint32_t *state, uint32_t *codep, uint32_t byte); |
Contributor
There was a problem hiding this comment.
I'd personally put this in a header file for utf8decoder.h, just to make it obvious where this function lives, but I'm just splitting hairs here 😛
Member
Author
There was a problem hiding this comment.
Done. I was just a bit lazy when I created that patch.
This way it is easier to identify the license of the code. Signed-off-by: Antonio Niño Díaz <antonio_nd@outlook.com>
With permission from the main authors [1], most of the code has been relicensed under the MIT license. SPDX license identifiers are used so that the license headers in source code files aren't too large. Add CONTRIBUTORS.rst file. [1] #128 Signed-off-by: Antonio Niño Díaz <antonio_nd@outlook.com>
AntonioND
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main contributors have agreed to relicense the code under the MIT license: #128
Some other files are still licensed under the ISC and BSD licenses, but they are compatible with the MIT license.
For now, the fact that all the rest of the codebase is consistent is enough.
In order not to have too long headers, I've used SPDX identifiers: https://spdx.org and https://github.com/david-a-wheeler/spdx-tutorial/blob/master/README.md
I've also added a
CONTRIBUTORS.rstfile.@csoren, @JustinLloyd, @vegard, @bentley, @stag019.