Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relicense codebase under the MIT license #225

Merged
merged 2 commits into from Jan 26, 2018
Merged

Relicense codebase under the MIT license #225

merged 2 commits into from Jan 26, 2018

Conversation

@AntonioND
Copy link
Member

@AntonioND AntonioND commented Jan 25, 2018

The main contributors have agreed to relicense the code under the MIT license: #128

Some other files are still licensed under the ISC and BSD licenses, but they are compatible with the MIT license.

For now, the fact that all the rest of the codebase is consistent is enough.

In order not to have too long headers, I've used SPDX identifiers: https://spdx.org and https://github.com/david-a-wheeler/spdx-tutorial/blob/master/README.md

I've also added a CONTRIBUTORS.rst file.

@csoren, @JustinLloyd, @vegard, @bentley, @stag019.

@AntonioND AntonioND force-pushed the relicense branch 3 times, most recently from cb4d24d to 4bc8cc3 Jan 25, 2018
Copy link
Contributor

@BenHetherington BenHetherington left a comment

Great to hear that progress has been made on this! The MIT licence sounds like a good choice to me, so RGBDS can be helpful for as many people and projects as possible 😊

@@ -91,6 +24,8 @@ uint32_t decode(uint32_t *state, uint32_t *codep, uint32_t byte)
#include "asm/main.h"
#include "asm/output.h"

uint32_t decode(uint32_t *state, uint32_t *codep, uint32_t byte);

This comment has been minimized.

@BenHetherington

BenHetherington Jan 26, 2018
Contributor

I'd personally put this in a header file for utf8decoder.h, just to make it obvious where this function lives, but I'm just splitting hairs here 😛

This comment has been minimized.

@AntonioND

AntonioND Jan 26, 2018
Author Member

Done. I was just a bit lazy when I created that patch.

@AntonioND AntonioND force-pushed the relicense branch from 4bc8cc3 to 50a3175 Jan 26, 2018
AntonioND added 2 commits Jan 26, 2018
This way it is easier to identify the license of the code.

Signed-off-by: Antonio Niño Díaz <antonio_nd@outlook.com>
With permission from the main authors [1], most of the code has been
relicensed under the MIT license.

SPDX license identifiers are used so that the license headers in source
code files aren't too large.

Add CONTRIBUTORS.rst file.

[1] #128

Signed-off-by: Antonio Niño Díaz <antonio_nd@outlook.com>
@AntonioND AntonioND force-pushed the relicense branch from 50a3175 to 1a5c423 Jan 26, 2018
@AntonioND AntonioND changed the title Relicense rgbasm, rgblink and rgbfix to MIT license Relicense codebase under the MIT license Jan 26, 2018
@AntonioND AntonioND merged commit 1a5c423 into develop Jan 26, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
github/pages GitHub Pages is building your site.
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AntonioND AntonioND deleted the relicense branch Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants