Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README events example added and orientation naming bug in orientationChange() #64

Merged
merged 3 commits into from Aug 9, 2015

Conversation

@elitan
Copy link

commented Jul 20, 2015

No description provided.

@elitan elitan changed the title PR README events example added and orientation naming bug in orientationChange() Jul 20, 2015

screenOrientation.setOrientation(orientation);
};

obj.unlockOrientation = function() {
screenOrientation.currOrientation = 'unlocked';
screen.orientation = screenOrientation.currOrientation;

This comment has been minimized.

Copy link
@gbenvenuti

gbenvenuti Jul 22, 2015

Owner

Hi @elitan

As the screen is passed in you should use obj rather than screen

i.e.

screenOrientation.currOrientation = obj.orientation = orientation;

This comment has been minimized.

Copy link
@elitan

elitan Jul 24, 2015

Author

I am not quit sure on what you mean and what changes you want to do. Could you clarify?

(I am rather new to Open Source in general)

@gbenvenuti

This comment has been minimized.

Copy link
Owner

commented Aug 9, 2015

Hi @elitan

Sorry for the delay. I'll merge your changes into the new release and make the change.

resolves #52

gbenvenuti added a commit that referenced this pull request Aug 9, 2015

Merge pull request #64 from elitan/master
README events example added and orientation naming bug in orientationChange()

@gbenvenuti gbenvenuti merged commit 1195b40 into gbenvenuti:master Aug 9, 2015

@mgcrea

This comment has been minimized.

Copy link

commented Oct 8, 2015

This merge did broke iOS. Looks like this Xperia has a different behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.