Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInconsistent predictions in 2.1.4 vs 2.1.3 #28
Comments
|
@WRobertLong Thanks for reporting the issue! The predictions are the same, but out of order. Should be an easy fix; however, it'll probably have to wait until this weekend or early next week. |
|
No worries - thank you ! |
|
The predictions are no longer accurate for the project I am working on. The predictions are varying based on the number of entries in the dataframe. Example: Predictions for 22 entries (1st entry is same as for one entry): Predictions for 84 entries (First 22 entries are same as before but results are different. This is same as what I got for the previous version): So instead of getting 0.5840900 for even that same single entry, I am getting a drastic difference of around 0.33, given that I am assigning a score between 0 and 1. |
|
@patel643 We think we found the issue; seems to be related this patch. Does the training data in your project include factors? If so, then this patch is likely the culprit and we can push a fix quickly. |
|
@bgreenwell Yes, it does. |
|
@patel643 thanks for reporting the issue, we'll try to have a patch in the next week or so! |
|
@WRobertLong and @patel643 I Just pushed a fix for this issue, can both of you confirm that the issue has been resolved? |
|
@bgreenwell I am still facing the issue. |
|
@patel643 It's difficult to diagnose the cause of your issue without a reproducible example. Could you post one so that we could better diagnose the cause of your issue? |
|
Also, I'm referring to the current development version of gbm: # install.packages("devtools")
devtools::install_github("gbm-developers/gbm")
library(gbm)
# <your-code> |
|
@bgreenwell The inconsistency issue has been resolved. Thank you! |
Here is a minimum working example to reproduce this problem, which did not occur in 2.1.3
The output from the last 2 lines is expected to be the same, and it is under 2.1.3, but not 2.1.4