Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect errror provided when testparms not found #221

Closed
arnonm-intel opened this issue Mar 29, 2020 · 1 comment
Closed

Incorrect errror provided when testparms not found #221

arnonm-intel opened this issue Mar 29, 2020 · 1 comment
Assignees
Labels

Comments

@arnonm-intel
Copy link

arnonm-intel commented Mar 29, 2020

For some reason, after changing samba versions, the testparm was not copied into the path.
Greyhole depends on it, and when it can't find it, provide an error that share XXX is found in greyhole.conf and not in smb.conf - which is the incorrect error.
Could be resolved with a fix in ConfigHelper.php to test if $config_test after the following line:

exec('testparm -s ' . escapeshellarg(self::$smb_config_file) . ' 2> /dev/null', $config_text);
@gboudreau gboudreau self-assigned this Mar 29, 2020
@gboudreau gboudreau added the Bug label Mar 29, 2020
@gboudreau
Copy link
Owner

Version 0.12.0 contains this fix. Thanks for taking the time to report this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants