Greg Brail gbrail

  • Apigee
  • Palo Alto, CA
  • Joined on

Organizations

@apigee @apigee-127
gbrail pushed to master at mozilla/rhino
@gbrail
  • 634d7c5
    Conversion of JSObject gives priority to Map than Interface implement…
gbrail pushed to master at mozilla/rhino
@gbrail
  • @tntim96 5cf7ee5
    Fix AST toSource emission for ES6 arrow function
gbrail commented on pull request mozilla/rhino#216
@gbrail

OK -- there was as previous commit that was blocking this one, which we had to revert because it was incomplete. So this one works now and there ar…

gbrail deleted branch tuchida-negative-test at mozilla/rhino
gbrail pushed to master at mozilla/rhino
@gbrail
gbrail merged pull request mozilla/rhino#216
@gbrail
negative test in test262
1 commit with 60 additions and 8 deletions
@gbrail
gbrail commented on issue mozilla/rhino#220
@gbrail

The arrow function implementation from @tuchida is quite an old PR and pre-dates the addition of test262 tests. We just need to enable those tests …

gbrail deleted branch greg-revert-max-length at mozilla/rhino
gbrail pushed to master at mozilla/rhino
@gbrail
gbrail commented on pull request mozilla/rhino#214
@gbrail

OK, sorry -- it looked fairly innocuous and it didn't cause existing tests to break. Let me revert it and then we can get back to fixing the various …

gbrail commented on issue mozilla/rhino#223
@gbrail

Normally I pass the source code (aka a String that represents the JavaScript that I want to run) as the second parameter to "evaluateString." Alter…

gbrail commented on pull request mozilla/rhino#120
@gbrail

Yes -- more tests for "toSource" would be great! We've been using either test262 or tests from the V8 test suite to test new features, but the pars…

gbrail opened issue mozilla/rhino#220
@gbrail
Add more tests for arrow functions
gbrail commented on pull request mozilla/rhino#120
@gbrail

Finally merged -- thanks! I'm going to open an issue to add more tests, however. For instance, perhaps we could add arrow function tests from the V…

gbrail deleted branch greg-gradle-snapshot at mozilla/rhino
gbrail pushed to master at mozilla/rhino
@gbrail
@gbrail
  • @gbrail ea12d0b
    Set the Maven artifactId in case Jenkins tries to override it.
gbrail pushed to master at mozilla/rhino
@gbrail
gbrail merged pull request mozilla/rhino#120
@gbrail
Implement ES6 Arrow Function
1 commit with 474 additions and 22 deletions
gbrail deleted branch tuchida-arrow_functions at mozilla/rhino
@gbrail
gbrail closed pull request mozilla/rhino#214
@gbrail
[WIP] Allow Array.prototype methods to handle array-like objects with length greater than 2^32 - 1
gbrail commented on pull request mozilla/rhino#214
@gbrail

Rebased and merged to master. Thanks!

gbrail commented on pull request mozilla/rhino#216
@gbrail

I am getting back in the swing of things now and just merged the fix from @sainaen on array prototype methods. Since I merged that one first, I see…