Switch branches/tags
Nothing to show
Commits on Nov 30, 2011
  1. Makefile fixes for systems with $CXX other than g++.

    Hans Wennborg committed Nov 30, 2011
    - Makefile: Use $(CXX) for compiling C++ files,
      don't override the environment's value of $CXX
    - build_detect_platform: use $CXX instead of g++.
    Based on bug report from Theo Schlossnagle:
    (Sync with uptream at 25807040.)
Commits on Nov 14, 2011
  1. Pass system's CFLAGS, remove exit time destructor, sstable bug fix.

    Hans Wennborg committed Nov 14, 2011
    - Pass system's values of CFLAGS,LDFLAGS.
      Don't override OPT if it's already set.
      Original patch by Alessio Treglia <>:
    - Remove 1 exit time destructor from leveldb.
    - Fix problem where sstable building code would pass an
      internal key to the user comparator.
    (Sync with uptream at 25436817.)
Commits on Oct 31, 2011
  1. A number of fixes:

    Hans Wennborg committed Oct 31, 2011
    - Replace raw slice comparison with a call to user comparator.
      Added test for custom comparators.
    - Fix end of namespace comments.
    - Fixed bug in picking inputs for a level-0 compaction.
      When finding overlapping files, the covered range may expand
      as files are added to the input set.  We now correctly expand
      the range when this happens instead of continuing to use the
      old range.  For example, suppose L0 contains files with the
      following ranges:
          F1: a .. d
          F2:    c .. g
          F3:       f .. j
      and the initial compaction target is F3.  We used to search
      for range f..j which yielded {F2,F3}.  However we now expand
      the range as soon as another file is added.  In this case,
      when F2 is added, we expand the range to c..j and restart the
      search.  That picks up file F1 as well.
      This change fixes a bug related to deleted keys showing up
      incorrectly after a compaction as described in Issue 44.
    (Sync with upstream @2507295)
Commits on Oct 5, 2011
  1. A number of bugfixes:

    Gabor Cselle committed Oct 5, 2011
    - Added DB::CompactRange() method.
      Changed manual compaction code so it breaks up compactions of
      big ranges into smaller compactions.
      Changed the code that pushes the output of memtable compactions
      to higher levels to obey the grandparent constraint: i.e., we
      must never have a single file in level L that overlaps too
      much data in level L+1 (to avoid very expensive L-1 compactions).
      Added code to pretty-print internal keys.
    - Fixed bug where we would not detect overlap with files in
      level-0 because we were incorrectly using binary search
      on an array of files with overlapping ranges.
      Added "leveldb.sstables" property that can be used to dump
      all of the sstables and ranges that make up the db state.
    - Removing post_write_snapshot support.  Email to leveldb mailing
      list brought up no users, just confusion from one person about
      what it meant.
    - Fixing static_cast char to unsigned on BIG_ENDIAN platforms.
      Fixes	Issue 35 and Issue 36.
    - Comment clarification to address leveldb Issue 37.
    - Change license in posix_logger.h to match other files.
    - A build problem where uint32 was used instead of uint32_t.
    Sync with upstream @2440862
Commits on Sep 26, 2011
  1. Sync with upstream @2421364.

    Hans Wennborg committed Sep 26, 2011
    Adding GNU/kFreeBSD support. As requested here:
    Use uint64_t instead of size_t in MemEnvTest. As pointed out at
Commits on Sep 12, 2011
  1. Sync with upstream @2386013.

    Hans Wennborg committed Sep 12, 2011
    Fix GCC -Wshadow warnings in LevelDB's public header files,
    reported by Dustin.
    Add in-memory Env implementation (helpers/memenv/*).
    This enables users to create LevelDB databases in-memory.
    Initialize ShardedLRUCache::last_id_ to zero.
    This fixes a Valgrind warning.
    (Also delete port/sha1_* which were removed upstream some time ago.)
Commits on Sep 1, 2011
  1. Bugfixes: for Get(), don't hold mutex while writing log. committed Sep 1, 2011
    - Fix bug in Get: when it triggers a compaction, it could sometimes
      mark the compaction with the wrong level (if there was a gap
      in the set of levels examined for the Get).
    - Do not hold mutex while writing to the log file or to the
      MANIFEST file.
      Added a new benchmark that runs a writer thread concurrently with
      reader threads.
      micros/op: avg  median 99   99.9  99.99  99.999 max
      before:    42   38     110  225   32000  42000  48000
      after:     24   20     55   65    130    1100   7000
    - Fixed race in optimized Get.  It should have been using the
      pinned memtables, not the current memtables.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Aug 22, 2011
  1. Bugfix for issue 33; reduce lock contention in Get(), parallel benchm… committed Aug 22, 2011
    - Fix for issue 33 (non-null-terminated result from
    - Support for running multiple instances of a benchmark in parallel.
    - Reduce lock contention on Get():
      (1) Do not hold the lock while searching memtables.
      (2) Shard block and table caches 16-ways.
      Benchmark for evaluating this change:
      $ db_bench --benchmarks=fillseq1,readrandom --threads=$n
      (fillseq1 is a small hack to make sure fillseq runs once regardless
      of number of threads specified on the command line).
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Aug 16, 2011
  1. Bugfixes for iterator and documentation. committed Aug 16, 2011
    - Fix bug in Iterator::Prev where it would return the wrong key.
      Fixes issues 29 and 30.
    - Added a tweak to testharness to allow running just some tests.
    - Fixing two minor documentation errors based on issues 28 and 25.
    - Cleanup; fix namespaces of export-to-C code.
      Also fix one "const char*" vs "char*" mismatch.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Aug 6, 2011
  1. @2302312 committed Aug 6, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Aug 5, 2011
  1. C binding for leveldb, better readseq benchmark for SQLite. committed Aug 5, 2011
    - Added a C binding for LevelDB.
      May be useful as a stable ABI that can be used by 
      programs that keep leveldb in a shared library, 
      or for JNI API.
    - Replaced SQLite's readseq benchmark to a more efficient version. 
      SQLite readseq speeds increased by about a factor of 2x 
      from the previous version. Also updated benchmark page to
      reflect readseq speed up.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jul 29, 2011
  1. Improved benchmark, fixed bugs and SQLite parameters. committed Jul 29, 2011
    - Based on suggestions on the sqlite-users mailing list,
      we removed the superfluous index on the primary key 
      for SQLite's benchmarks, and turned write-ahead logging 
      ("WAL") on. This led to performance improvements for SQLite.
    - Based on a suggestion by Florian Weimer on the leveldb
      mailing list, we disabled hard drive write-caching via
      hdparm when testing synchronous writes. This led to
      performance losses for LevelDB and Kyoto TreeDB.
    - Fixed a mistake in 2.A.->Random where the bar sizes
      were switched for Kyoto TreeDB and SQLite.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jul 27, 2011
  1. Minor typos in benchmark page. committed Jul 27, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  2. Minor edit in benchmark page. committed Jul 27, 2011
    (Baseline comparison does not make sense for large values.)
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  3. Setting SVN mime-type for benchmark page. committed Jul 27, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  4. Adding doctype to benchmark page so Google Code displays it as HTML. committed Jul 27, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  5. Adding FreeBSD support, removing Chromium files, adding benchmark. committed Jul 27, 2011
    - LevelDB patch for FreeBSD. This resolves Issue 22.
      Contributed by dforsythe (thanks!).
    - Removing Chromium-specific files.
      They are now going to live in the Chromium repository.
    - Adding a benchmark page comparing LevelDB performance
      to SQLite and Kyoto Cabinet's TreeDB, along with
      code to generate the benchmarks.
      Thanks to Kevin Tseng for compiling the benchmarks,
      and Scott Hess and Mikio Hirabayashi for their
      help and advice.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jul 21, 2011
  1. Speed up Snappy uncompression, new Logger interface. committed Jul 21, 2011
    - Removed one copy of an uncompressed block contents changing
      the signature of Snappy_Uncompress() so it uncompresses into a
      flat array instead of a std::string.
      Speeds up readrandom ~10%.
    - Instead of a combination of Env/WritableFile, we now have a
      Logger interface that can be easily overridden applications
      that want to supply their own logging.
    - Separated out the gcc and Sun Studio parts of atomic_pointer.h
      so we can use 'asm', 'volatile' keywords for Sun Studio.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jul 19, 2011
  1. Sun Studio support, and fix for test related memory fixes. committed Jul 19, 2011
    - LevelDB patch for Sun Studio
      Based on a patch submitted by Theo Schlossnagle - thanks!
      This fixes Issue 17.
    - Fix a couple of test related memory leaks.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jul 15, 2011
  1. Small tweaks and bugfixes for Issue 18 and 19. committed Jul 15, 2011
    Slight tweak to the no-overlap optimization: only push to
    level 2 to reduce the amount of wasted space when the same
    small key range is being repeatedly overwritten.
    Fix for Issue 18: Avoid failure on Windows by avoiding
    deletion of lock file until the end of DestroyDB().
    Fix for Issue 19: Disregard sequence numbers when checking for 
    overlap in sstable ranges. This fixes issue 19: when writing 
    the same key over and over again, we would generate a sequence 
    of sstables that were never merged together since their sequence
    numbers were disjoint.
    Don't ignore map/unmap error checks.
    Miscellaneous fixes for small problems Sanjay found while diagnosing
    issue/9 and issue/16 (corruption_testr failures).
    - log::Reader reports the record type when it finds an unexpected type.
    - log::Reader no longer reports an error when it encounters an expected
      zero record regardless of the setting of the "checksum" flag.
    - Added a missing forward declaration.
    - Documented a side-effects of larger write buffer sizes
      (longer recovery time).
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jun 30, 2011
  1. Fixed a snappy compression wrapper bug (passing wrong variable). committed Jun 30, 2011
    Change atomic_pointer.h to prefer a memory barrier based
    implementation over a <cstdatomic> based implementation for
    the following reasons:
    (1) On a x86-32-bit gcc-4.4 build, <ctdatomic> was corrupting
        the AtomicPointer.
    (2) On a x86-64-bit gcc build, a <ctstdatomic> based acquire-load
        takes ~15ns as opposed to the ~1ns for a memory-barrier
        based implementation.
    Fixes issue 9 (corruption_test fails)
    Fixes issue 16 (CorruptionTest.MissingDescriptor fails)
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jun 29, 2011
  1. Fixing Makefile issue reported in Issue 15 (misspelled flag) committed Jun 29, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  2. Platform detection during build, plus compatibility patches for machi… committed Jun 29, 2011
    …nes without <cstdatomic>.
    This revision adds two major changes:
    1. build_detect_platform which generates
       with platform-dependent flags for the build process
    2. /port/atomic_pointer.h with anAtomicPointerimplementation
       for platforms without <cstdatomic>
    Some of this code is loosely based on patches submitted to the 
    LevelDB mailing list at!forum/leveldb
    Tip of the hat to Dave Smith and Edouard A, who both sent patches.
    The presence of Snappy ( and
    cstdatomic are now both detected in the build_detect_platform
    script (1.) which gets executing during make.
    For (2.), instead of broadly importing atomicops_* from Chromium or
    the Google performance tools, we chose to just implement AtomicPointer 
    and the limited atomic load and store operations it needs. 
    This resulted in much less code and fewer files - everything is 
    contained in atomic_pointer.h.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jun 22, 2011
  1. Fixing issue 11: was missing committed Jun 22, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  2. A number of smaller fixes and performance improvements: committed Jun 22, 2011
    - Implemented Get() directly instead of building on top of a full
      merging iterator stack.  This speeds up the "readrandom" benchmark
      by up to 15-30%.
    - Fixed an opensource compilation problem.
      Added --db=<name> flag to control where the database is placed.
    - Automatically compact a file when we have done enough
      overlapping seeks to that file.
    - Fixed a performance bug where we would read from at least one
      file in a level even if none of the files overlapped the key
      being read.
    - Makefile fix for Mac OSX installations that have XCode 4 without XCode 3.
    - Unified the two occurrences of binary search in a file-list
      into one routine.
    - Found and fixed a bug where we would unnecessarily search the
      last file when looking for a key larger than all data in the
    - A fix to avoid the need for trivial move compactions and
      therefore gets rid of two out of five syncs in "fillseq".
    - Removed the MANIFEST file write when switching to a new
      memtable/log-file for a 10-20% improvement on fill speed on ext4.
    - Adding a SNAPPY setting in the Makefile for folks who have
      Snappy installed. Snappy compresses values and speeds up writes.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jun 7, 2011
  1. sync with upstream @2170699 committed Jun 7, 2011
    Fixed race condition reported by Dave Smit (dizzyd@dizzyd,com)
    on the leveldb mailing list.  We were not signalling
    waiters after a trivial move from level-0.  The result was
    that in some cases (hard to reproduce), a write would get
    stuck forever waiting for the number of level-0 files to drop
    below its hard limit.
    The new code is simpler: there is just one condition variable
    instead of two, and the condition variable is signalled after
    every piece of background work finishes.  Also, all compaction
    work (including for manual compactions) is done in the
    background thread, and therefore we can remove the
    "compacting_" variable.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Jun 2, 2011
  1. sync with upstream @2162758 committed Jun 2, 2011
    Minor changes:
    * Reformat the bodies of the iterator interface routines in IteratorWrapper to
      make them a bit easier to read
    * Switched the default in the leveldb makefile to be optimized mode, rather
      than debug mode
    * Fix build problem in chromium port
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on May 28, 2011
  1. Update from upstream @2155199 committed May 28, 2011
    * Patch LevelDB to build for OSX and iOS
    * Fix race condition in memtable iterator deletion.
    * Other small fixes.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on May 21, 2011
  1. sync with upstream @ 21409451 committed May 21, 2011
    Check the NEWS file for details of what changed.
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on May 3, 2011
  1. make windows include /Iport\win in dependent projects committed May 3, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Apr 21, 2011
  1. pull in hans' mac build fix committed Apr 21, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Apr 20, 2011
  1. fix build on at least linux committed Apr 20, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  2. @2077630 committed Apr 20, 2011
    * should not export symbols.
    * Fix MSVC warnings.
    * Removed large value support.
    * Fix broken reference to documentation file
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
Commits on Apr 19, 2011
  1. reverting disastrous MOE commit, returning to r21 committed Apr 19, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529
  2. Revision created by MOE tool push_codebase. committed Apr 19, 2011
    git-svn-id: 62dab493-f737-651d-591e-8d6aee1b9529