-
Notifications
You must be signed in to change notification settings - Fork 39
Role landing pages #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shawnthompson
merged 15 commits into
gc-da11yn:main
from
shawnthompson:feature/role-system-not-tagged
Sep 25, 2025
Merged
Role landing pages #733
shawnthompson
merged 15 commits into
gc-da11yn:main
from
shawnthompson:feature/role-system-not-tagged
Sep 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add comprehensive roles.js with W3C ARRM role definitions - Add rolePairs.js for role page generation - Add groupPairsEn.js and groupPairsFr.js for role group organization - Define 13 accessibility roles across 4 role groups - Include bilingual role labels and detailed job descriptions
- Update .eleventy.js with role filtering functions (byRole, byAnyRole) - Add role-group-sections.njk partial for displaying role groups - Add role-mini-toc.njk partial for role navigation - Enable role-based content filtering across the site
- Add role.njk templates for individual role pages (English/French) - Add roles-group.njk templates for role group pages - Add roles/index.njk landing pages with role filtering interface - Include W3C ARRM role descriptions and job titles - Enable bilingual role-based content discovery
- Add role column to pageListTable.njk with badge display - Update pageLabel.njk to show role badges for content - Enhance breadcrumbs.njk with role-based navigation - Modify tagList.js to include role and roleGroup tags - Enable visual role identification across all pages
- Convert tag labels from Title Case to sentence case for consistency - Add 'roles' entries for both English and French subjects
- Add CSV download functionality to page list table - Implement git creation dates in CSV exports using computed data - Add new columns: Layout, Date Modified, Date Created, Content Type - Fix Nunjucks template syntax issues with conditional blocks
- Remove blank lines at top of CSV files using Nunjucks whitespace control - Add UTF-8 BOM transform for proper French accent encoding in Excel - Translate content type values in French CSV from English to French: - 'Landing Page' → 'Page d'atterrissage' - 'Content Page' → 'Page de contenu' - 'Link' → 'Lien' This ensures both English and French CSV exports work correctly with proper encoding and localized content.
- Standardize tag labels to sentence case - Reorganize subjects structure for better categorization - Prepare tag system for content organization
…xclusion • Add eleventyExcludeFromCollections to all role pages until content tagging begins • Create reusable role-content-coming-soon.njk partial for consistent messaging • Add internationalized role content messages to alerts.js data file • Update role pages to show 'Coming soon' messages when no content is tagged • Fix role group TOC to display all roles regardless of content availability • Ensure consistent user experience across individual and group role pages
- Create shared content type macro in src/_includes/macros/contentType.njk - Update HTML table and CSV templates to use unified content type logic - Remove 'Other language link' column from HTML page list table - Maintain UTF-8 BOM encoding and French translations in CSV exports This ensures consistency between HTML table and CSV exports while simplifying the table interface.
✅ Deploy Preview for a11ycanada ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not delete the following line
@netlify /en/pages-to-review/
Adding roles landing pages to site to be ready for when we start tagging the content pages with
rolein the front matter.To see examples of how this will work, check out examples in PR #731