New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving doc for Record.ts #1574
Conversation
Added doc comments for most members of Record.ts. No changes to the code.
Co-authored-by: Eric Crosson <EricCrosson@users.noreply.github.com>
Applying suggestions from @EricCrosson for: - the overview comment comment - consistent spelling for '2' vs 'two'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got tired so am ending my review here, a testament to the amount of work you've put into this. Documentation like this is extremely valuable to this ecosystem, thank you so much for contributing it.
Thank you so much for every feedback. I'll make one commit trying to address all the points you raised. |
This is awesome! Thank you for your hard work on this, @fmpanelli! |
@fmpanelli @samhh Is there anything else you guys would like to add here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding this @fmpanelli, it's tremendously helpful 💖
I've left a few suggestions based on a quick read through for any typos.
Co-authored-by: Alex Ketch <alex-ketch@users.noreply.github.com>
Co-authored-by: Alex Ketch <alex-ketch@users.noreply.github.com>
I did not expect so much attention and so much feedback ❤️ |
The suggestion will be addressed with a specific github issue.
I fixed the lint problems (it was enough to remove a couple of trailing spaces). I improved the documentation further. |
I just aligned the documentation for |
Hi, I haven't seen any further comment. |
Thank you @fmpanelli |
Added documentation comments for most members of Record.ts. No changes to the code.