Allow Lazarus versions to fall through in switch-case #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toolchain installation logic can treat whole ranges of Lazarus versions as a *single* case instead of copy-pasting the same code under each individual case. This makes the code easier to read and update; new Lazarus versions will only require a single added line when the installation steps don't require changes.
|
Hey @rdipardo, I quite like it this way! I'll merge it 😄 I still have some very persistent issues with cache in Windows and, from my most recent tests, in macOS to solve and I'll do a release once I've had time to get to the bottom of this retched cache misbehaviour !! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolchain installation logic can treat whole ranges of Lazarus versions as a single case instead of copy-pasting the same code under each individual case.
This makes the code easier to read and update; new Lazarus versions will only require a single added line when the installation steps don't require changes.