Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to disable relay of free (super low fee) transactions #383

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Default to disable relay of free (super low fee) transactions #383

merged 1 commit into from
Jul 10, 2020

Conversation

zquestz
Copy link
Contributor

@zquestz zquestz commented Jul 10, 2020

While I love the idea of relaying a percentage of transactions with a low fee, the rest of the network just doesn't accept them. Therefore, this PR updates defaultFreeTxRelayLimit to 0.

  • This makes sure submitted transactions with too low a fee get an error
  • This can still be activated manually if people want to attempt to relay low fee transactions.

Should help mitigate issues seen by read.cash in #382

@zquestz zquestz requested a review from cpacia July 10, 2020 00:19
@zquestz zquestz merged commit ef872e9 into master Jul 10, 2020
@zquestz zquestz deleted the default-no-free-relay branch July 10, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpacia cpacia cpacia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zquestz @cpacia