- add regex group names #1684
Closed
- add regex group names #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using regex operation, if including named capture groups then output the name of the group in the 'List matches with capture groups' output format.
a3957273
requested changes
Feb 4, 2024
| @@ -207,7 +207,7 @@ function regexList(input, regex, displayTotal, matches, captureGroups) { | |||
| if (captureGroups) { | |||
| for (let i = 1; i < match.length; i++) { | |||
| if (matches) { | |||
| output += " Group " + i + ": "; | |||
| output += " Group " + i + " (" + regex.xregexp.captureNames[i - 1] + "): "; | |||
There was a problem hiding this comment.
There needs to be a check to ensure that the current group is named. Otherwise, in the case of no names there is the following error:
Invalid regex. Details: regex.xregexp.captureNames is null
And if there are some that are named and some that are not, the unnamed ones gain a label of 'null', which isn't ideal.
|
Hey, I'm going to close this PR because it doesn't support existing unnamed regular expressions. Feel free to recreate the PR if you update this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1650
I've recently been using the regex operation with named capture groups. However the name of the group isn't surfaced in the output, and would be handy when I have a lot of groups.
Saw that this is an existing feature request, so added this in.
Test link with data and operation
Thanks