Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LAN server for CommunicationsPi #64

Merged
merged 4 commits into from Mar 9, 2020
Merged

Conversation

@PrabhanshuAttri
Copy link
Member

PrabhanshuAttri commented Mar 9, 2020

No description provided.

daisycrego and others added 4 commits Mar 8, 2020
HardwareTeam: Sprint1
…cs-gy-9223-class into feat/communications
Copy link
Contributor

ab7289 left a comment

Please update the target to hardware-team, otherwise looks good.

@PrabhanshuAttri PrabhanshuAttri changed the base branch from master to hardware-team Mar 9, 2020
@PrabhanshuAttri

This comment has been minimized.

Copy link
Member Author

PrabhanshuAttri commented Mar 9, 2020

How the hell I forget changing the base branch? 😠 I remember it while pushing the code. Need to add a message to the pre-commit hook.

@PrabhanshuAttri

This comment has been minimized.

Copy link
Member Author

PrabhanshuAttri commented Mar 9, 2020

@Ricardo-1894 Any reason to close this PR?

@ab7289
ab7289 approved these changes Mar 9, 2020
Copy link
Contributor

ab7289 left a comment

LGTM!

@ab7289 ab7289 merged commit 1edf078 into hardware-team Mar 9, 2020
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 98.404%
Details
@Ricardo-1894

This comment has been minimized.

Copy link
Contributor

Ricardo-1894 commented Mar 9, 2020

@Ricardo-1894 Any reason to close this PR?

My fault, I thought it was going to merge into class master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.