Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hardware directory structure #48

Merged
merged 4 commits into from Mar 3, 2020
Merged

Conversation

@PrabhanshuAttri
Copy link
Member

PrabhanshuAttri commented Mar 3, 2020

#43

Merge pull request #8 from gcivil-nyu-org/fix-develop
@PrabhanshuAttri PrabhanshuAttri force-pushed the feat/hardware-init branch from 5939de1 to 332521e Mar 3, 2020
@ab7289

This comment has been minimized.

Copy link
Contributor

ab7289 commented Mar 3, 2020

Should we be PR'ing this directly into Master @PrabhanshuAttri ?

Copy link
Contributor

ab7289 left a comment

We should be PR'ing this into develop before master

@PrabhanshuAttri PrabhanshuAttri changed the base branch from master to develop Mar 3, 2020
@PrabhanshuAttri

This comment has been minimized.

Copy link
Member Author

PrabhanshuAttri commented Mar 3, 2020

I have switched the base to develop. Thanks for pointing this out

@ab7289 ab7289 self-requested a review Mar 3, 2020
Copy link
Contributor

ab7289 left a comment

LGTM!

@ab7289
ab7289 approved these changes Mar 3, 2020
@PrabhanshuAttri PrabhanshuAttri merged commit 131e282 into develop Mar 3, 2020
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage remained the same at 99.437%
Details
ab7289 pushed a commit that referenced this pull request Mar 5, 2020
Ignore .idea and .DS_Store
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.