Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage report for gcovr #216

Closed
mayeut opened this issue Feb 14, 2018 · 3 comments
Closed

Add coverage report for gcovr #216

mayeut opened this issue Feb 14, 2018 · 3 comments

Comments

@mayeut
Copy link
Contributor

@mayeut mayeut commented Feb 14, 2018

IMHO, gcovr is missing a public coverage report on CI builds.

It would allow:

  • To track coverage progress when adding tests, before refactoring gcovr
  • To make sure PR are well tested and reject PR that have an insufficient diff coverage
  • For everyone to know what's tested

There are at least 2 service providers that allow to get a report on each CI build that I know of:

  • codecov
  • coveralls

Here's a sample output using codecov: https://codecov.io/gh/mayeut/gcovr/branch/module-coverage

@latk
Copy link
Member

@latk latk commented Feb 14, 2018

Absolutely! I'd like this very much. I'm not familiar with any particular provider so I'll leave that choice at your discretion. If in doubt, we can do both :) Please let me know If I should create an account or something.

I'm not sure if any of these services can integrate with GH as a pull request check (like Travis and Appveyor do), but even having informational code coverage around somewhere else is going to be quite useful. My main motivation for having coverage is that I can see which behaviour is not tested (e.g. the --exclude-directories option) because those parts are possibly broken and require further scrutiny.

If you already know how to configure the coverage collection, a PR or a pointer to the instructions would be welcome.

@mayeut
Copy link
Contributor Author

@mayeut mayeut commented Feb 14, 2018

I know that codecov does indeed integrate as a pull request check. I don't know about coveralls.

In order to enable codecov, you just need to login using your GitHub account and add the gcovr repository. I don't know how it works with organization accounts though.
Once this is done, I can create a Pull Request using my existing branch doing CI coverage on my fork.

@latk
Copy link
Member

@latk latk commented Feb 15, 2018

OK, I've activated codecov on the gcovr/gcovr repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants