New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should check for more BASE_OS types in Windows #240

Closed
landofcake opened this Issue Mar 7, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@landofcake
Contributor

landofcake commented Mar 7, 2018

This is a follow on from #230 . The tests currently don't work correctly in any Windows build environment which doesn't perfectly expose MSYS_NT as part of uname where everything would be absolutely fine otherwise.

For instance, in my case, I'm building and running everything in a MinGW/MSYS environment which happens to expose uname in a way that causes BASE_OS to resolve to MINGW_NT.

In this instance, if you simply tell the test makefiles to use everything as if we had returned MSYS_NT, everything is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment