Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html-details produces output as print_text_report, not print_html_report #93

Closed
theold190 opened this issue May 26, 2015 · 3 comments
Closed

Comments

@theold190
Copy link

@theold190 theold190 commented May 26, 2015

Right now if you specify --html-details flag the output will be done using print_text_report, and not print_html_report. A fix like this should remove the issue:

diff --git a/scripts/gcovr b/scripts/gcovr
index 792aece..fd83523 100755
--- a/scripts/gcovr
+++ b/scripts/gcovr
@@ -2176,7 +2176,7 @@ if options.verbose:
 #
 if options.xml or options.prettyxml:
     print_xml_report(covdata)
-elif options.html:
+elif options.html or options.html_details:
     print_html_report(covdata, options.html_details)
 else:
     print_text_report(covdata)
@daantimmer
Copy link

@daantimmer daantimmer commented Oct 2, 2015

Another solution that i see being used is using --html --html-details

@latk
Copy link
Member

@latk latk commented Feb 11, 2018

Good find! The --html-details option should imply --html, just like --xml-pretty implies --xml. I'd welcome a pull request for this :)

@theold190
Copy link
Author

@theold190 theold190 commented Feb 12, 2018

Nice! Feel free to close the issue if the fix from art-of-dom works as expected.

@latk latk closed this in #211 Feb 12, 2018
latk added a commit that referenced this issue Feb 12, 2018
JamesReynolds pushed a commit to JamesReynolds/gcovr that referenced this issue Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants