New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix common prefix detection for files #103

Merged
merged 1 commit into from Aug 6, 2016

Conversation

Projects
None yet
3 participants
@bbreinbauer

bbreinbauer commented Jun 8, 2015

if all files names start with the same string this string
will be removed by commonprefix. Use dirs as input for
commonprefix.

Bernhard Breinbauer
fix commonprefix detection for files
if all files names start with the same string this string
will be removed by commonprefix. Use dirs as input for
commonprefix.
@kianooshm

This comment has been minimized.

kianooshm commented on 8062a75 Jul 23, 2015

Thanks for your patch. Solved my problem. An extra character was being removed from the beginning of file names so I (hackishly) got rid of "... + os.sep" in line 1470.

@whart222 whart222 merged commit 8062a75 into gcovr:master Aug 6, 2016

@whart222

This comment has been minimized.

Member

whart222 commented Aug 6, 2016

I've merged this PR, but I would like to see a test added that demonstrates this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment