Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added coverage_min argument #116

Closed
wants to merge 1 commit into from
Closed

Conversation

@krichter722
Copy link

@krichter722 krichter722 commented Sep 9, 2015

which makes the process return with a value != 0 if a minimal coverage isn't reached for all files

based on #115 (will rebase as soon as #115 is merged)

@krichter722 krichter722 force-pushed the krichter722:coverage_min branch from 7390fa3 to a95f6e1 Sep 10, 2015
…missing commands, help message and minimizes maintainance efforts); removed usage of options dictionary because exposing function arguments provides more API stability and improves code quality; added incomplete (for installation, distribution and pypi upload) setup.py to facilitate the installation of plac
@krichter722 krichter722 force-pushed the krichter722:coverage_min branch from a95f6e1 to be9d919 Sep 10, 2015
krichter722 referenced this pull request in krichter722/check Dec 25, 2015
…e check or failure if a certain coverage isn't reached to Makefile.am and check for presence of gcovr and customization from https://github.com/krichter722/gcovr to configure.ac
@whart222
Copy link
Member

@whart222 whart222 commented Aug 6, 2016

Since this is based on #115, I'm deferring this.

@latk
Copy link
Member

@latk latk commented Jan 8, 2018

This is now a duplicate of #173 which adds a similar option, with a few differences. Importantly, #173 outputs the reports even when the coverage level fails.

I am not sure whether a per-project or per-file coverage criterion is better. If you had a specific use case in mind for a per-file minimum coverage, maybe that can be added as well.

@latk latk closed this Jan 8, 2018
@krichter722 krichter722 deleted the krichter722:coverage_min branch Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants