Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcov '/'s breaking --html-details on Windows #157

Merged
merged 1 commit into from Jan 7, 2018

Conversation

@jessicalevine
Copy link
Contributor

@jessicalevine jessicalevine commented Nov 23, 2016

The gcov reports (from which gcovr output is generated) use '/' as the
path separator in filenames, regardless of the path separator used by
the operating system. This breaks attempts to read files located in
subdirectories while generating --html-details reports on Windows.

This commit fixes the issue by replacing '/'s present in the gcov
filename with Python's OS-sensitive os.sep character.

The gcov reports (from which gcovr output is generated) use '/' as the
path separator in filenames, regardless of the path separator used by
the operating system. This breaks attempts to read files located in
subdirectories while generating --html-details reports on Windows.

This commit fixes the issue by replacing '/'s present in the gcov
filename with Python's OS-sensitive os.sep character.
Copy link

@aoreskovic aoreskovic left a comment

I have been using this on Windows 7, and this fix works flawlessly.

@Flockstud
Copy link

@Flockstud Flockstud commented Sep 21, 2017

This works well, I had to manually add your changes in, but works perfectly! This needs to be merged to the master!

@latk latk requested review from sinelaw and latk Dec 27, 2017
@latk
latk approved these changes Dec 27, 2017
latk added a commit to latk/gcovr that referenced this pull request Jan 7, 2018
Fix gcov '/'s breaking --html-details on Windows
@latk latk merged commit dd3aca3 into gcovr:master Jan 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@latk latk removed the request for review from sinelaw Jan 7, 2018
@latk latk removed the needs review label Jan 20, 2018
JamesReynolds pushed a commit to JamesReynolds/gcovr that referenced this pull request Mar 8, 2018
Fix gcov '/'s breaking --html-details on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants